1699904 - Perma xpc test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature network.http.http3.enabled should match runtime value. - false == true when Gecko 88 merges to Beta on 2021-03-22

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Cosmin Sabou [:CosminS]]

• Central-as-beta simulation
• How to run these simulations
• Failure log

[task 2021-03-20T10:32:54.506Z] 10:32:54     INFO -  TEST-PASS | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature fission.autostart should match runtime value. - false == false
[task 2021-03-20T10:32:54.506Z] 10:32:54  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature network.http.http3.enabled should match runtime value. - false == true
[task 2021-03-20T10:32:54.506Z] 10:32:54     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/featuregates/test/unit/test_FeatureGate.js:testAllDefaultsMatchSettings:440
[task 2021-03-20T10:32:54.507Z] 10:32:54     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:239
[task 2021-03-20T10:32:54.507Z] 10:32:54     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:567
[task 2021-03-20T10:32:54.507Z] 10:32:54     INFO -  -e:null:1
[task 2021-03-20T10:32:54.508Z] 10:32:54     INFO -  exiting test
[task 2021-03-20T10:32:54.508Z] 10:32:54     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2021-03-20T10:32:54.508Z] 10:32:54     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:830:20
[task 2021-03-20T10:32:54.509Z] 10:32:54     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:931:5
[task 2021-03-20T10:32:54.509Z] 10:32:54     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:73:21
[task 2021-03-20T10:32:54.510Z] 10:32:54     INFO -  proto.report@resource://testing-common/Assert.jsm:233:10
[task 2021-03-20T10:32:54.510Z] 10:32:54     INFO -  equal@resource://testing-common/Assert.jsm:275:8
[task 2021-03-20T10:32:54.510Z] 10:32:54     INFO -  testAllDefaultsMatchSettings@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/featuregates/test/unit/test_FeatureGate.js:440:12
[task 2021-03-20T10:32:54.511Z] 10:32:54     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:239:6
[task 2021-03-20T10:32:54.512Z] 10:32:54     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:567:5
[task 2021-03-20T10:32:54.512Z] 10:32:54     INFO -  @-e:1:1
[task 2021-03-20T10:32:54.512Z] 10:32:54     INFO -  exiting test
[task 2021-03-20T10:32:54.513Z] 10:32:54     INFO -  PID 23103 | [Parent 23103, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:3352
[task 2021-03-20T10:32:54.513Z] 10:32:54     INFO -  PID 23103 | [Parent 23103, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4442
[task 2021-03-20T10:32:54.514Z] 10:32:54     INFO -  PID 23103 | [Parent 23103, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:202
[task 2021-03-20T10:32:54.514Z] 10:32:54     INFO -  PID 23103 | [Parent 23103, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:202
[task 2021-03-20T10:32:54.514Z] 10:32:54     INFO -  <<<<<<<
[task 2021-03-20T10:32:54.514Z] 10:32:54     INFO -  INFO | Result summary:
[task 2021-03-20T10:32:54.515Z] 10:32:54     INFO -  INFO | Passed: 771
[task 2021-03-20T10:32:54.515Z] 10:32:54  WARNING -  INFO | Failed: 1
[task 2021-03-20T10:32:54.515Z] 10:32:54  WARNING -  One or more unittests failed.
[task 2021-03-20T10:32:54.515Z] 10:32:54     INFO -  INFO | Todo: 0
[task 2021-03-20T10:32:54.515Z] 10:32:54     INFO -  INFO | Retried: 1
[task 2021-03-20T10:32:54.515Z] 10:32:54     INFO -  SUITE-END | took 575s
[task 2021-03-20T10:32:54.515Z] 10:32:54     INFO -  Node moz-http2 server shutting down ...
[task 2021-03-20T10:32:54.515Z] 10:32:54     INFO -  http3Server server shutting down ...
[task 2021-03-20T10:32:54.600Z] 10:32:54    ERROR - Return code: 1

Comment 1

[Dragana Damjanovic [:dragana]]

Can you help me how to fix that?

I though this was ok for beta:

default-value = {default = false, nightly = true, beta = true}

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The issue is with how FeatureGate determines the beta variable (it checks the update channel) while the failed platforms (debug, asan) use default as the update channel. It also wouldn't match for late beta, I plan to provide a patch to fix this, likely with the values from AppConstants as support variables.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1699904 - skip test_FeatureGate.js on asan+debug and let HTTP/3 feature depend on EARLY_BETA_OR_EARLIER

asan and debug builds are always set to the 'default' update channel (used by
FeatureGate to determine the build channel) while the independent build channel
determines conditional variables depending on it.

The HTTP/3 feature preference network.http.http3.enabled depends on the
variable EARLY_BETA_OR_EARLIER since bug 1699490).

Comment 4

[Dragana Damjanovic [:dragana]]

Thanks, Sebastian!

Comment 5

[Andreea Pavel [:apavel]]

Patch works in latest beta sim: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=208e86facf3bfc82684d27cce23e036699192c4b&searchStr=xpc

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5837ae1213d8
skip test_FeatureGate.js on asan+debug and let HTTP/3 feature depend on EARLY_BETA_OR_EARLIER r=preferences-reviewers,Gijs

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 9210539 [details]
Bug 1699904 - skip test_FeatureGate.js on asan+debug and let HTTP/3 feature depend on EARLY_BETA_OR_EARLIER

Beta/Release Uplift Approval Request

• User impact if declined: The "Experimental Features" pane in the Options might be out of sync with the preference value during Late Beta. Else this patch avoids test failures.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch performs 3 changes
• skips the problematic test on asan and debug if the builds are not nightly builds because these configs use the update channel 'default' while the other builds use the normal update channel for the branch (e.g. 'beta'). FeatureGate checks that channel to determine the branch.
• add support for the variable early_beta_or_earlier to FeatureGate
• adjust the default value for the feature using network.http.http3.enabled to align it with the rules which determine the default value of the preference during the build process
• String changes made/needed: N/A

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9210539 [details]
Bug 1699904 - skip test_FeatureGate.js on asan+debug and let HTTP/3 feature depend on EARLY_BETA_OR_EARLIER

Approved for 88.0b1.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c518f3e6b14b

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5837ae1213d8