1699917 - Remove --panel-border-radius common.css variable

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P3)

Description

[Tim Nguyen :ntim]

It should be 4px or 8px on all platforms with proton. Let's just inline that value and remove the variable, since the value no longer changes depending on the platform.

Also, --panel-border-radius is misused in about:logins, another reason to remove this variable.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1699917 - Make menu styles consistent & remove --panel-border-radius common.css variable. r=#desktop-theme-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99ce41916bb2
Make menu styles consistent & remove --panel-border-radius common.css variable. r=robwu

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_parsable_css.js along with Bug 1701448

backout: https://hg.mozilla.org/integration/autoland/rev/9eaad0de20ae76bdc98f3e8d82f5e39b40681a93

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=3693f90f395dee3127a99f18ad1434ddc1300b33&group_state=expanded&selectedTaskRun=DwugoB6vT9OjoGP2wTkeGg.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=335472074&repo=autoland&lineNumber=1618

[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - Buffered messages finished
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--blue-40-a10` is not referenced - 
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - Stack trace:
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - chrome://mochikit/content/browser-test.js:test_ok:1334
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:448
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--grey-90` is not referenced - 
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - Stack trace:
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - chrome://mochikit/content/browser-test.js:test_ok:1334
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:448
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-has-dir-attr’.  Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}

Comment 4

[Natalia Csoregi [:nataliaCs]]

ni :dao as :ntim has requests blocked

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7e4149603de
Make menu styles consistent & remove --panel-border-radius common.css variable. r=robwu

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e7e4149603de