1699997 - Remove remaining callback-style functions in apz_test_native_event_utils.js

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Description

[Kartikaya Gupta (email:[e-mail])]

After the changes in bug 1666295's dependencies, most of the APZ tests and helper functions have been migrated from callback-style to promise or async/await-style. There's a handful of functions left over in apz_test_native_event_utils that still take a callback function, and can be removed pretty easily. This bug will do that.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/jobs?repo=try&revision=91ef678721e2e469798254d48ed8dc0e896bffc8

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1699997 - Convert synthesizeNativeWheelAndWaitForObserver from callback-style to promise-style. r?botond

This function has only one caller, which was trivial to migrate.

Depends on D109245

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1699997 - Remove synthesizeNativeWheelAndWaitForScrollEvent and migrate callers to promiseNativeWheelAndWaitForScrollEvent. r?botond

Depends on D109246

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1699997 - Remove unused synthesizeNativeMouseEventWithAPZAndWaitForEvent function. r?botond

It was only used by the promise-style equivalent, so this folds the two together.

Depends on D109247

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1699997 - Remove unused moveMouseAndScrollWheelOver function. r?botond

Everybody uses the promise-style equivalent so we can just move over
the documentation and drop the function.

Depends on D109248

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34cbd820c7bd
Convert synthesizeNativeWheelAndWaitForObserver from callback-style to promise-style. r=botond
https://hg.mozilla.org/integration/autoland/rev/855b75b8db8f
Remove synthesizeNativeWheelAndWaitForScrollEvent and migrate callers to promiseNativeWheelAndWaitForScrollEvent. r=botond
https://hg.mozilla.org/integration/autoland/rev/2cc9b5cace93
Remove unused synthesizeNativeMouseEventWithAPZAndWaitForEvent function. r=botond
https://hg.mozilla.org/integration/autoland/rev/b1246187a93d
Remove unused moveMouseAndScrollWheelOver function. r=botond

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/34cbd820c7bd
https://hg.mozilla.org/mozilla-central/rev/855b75b8db8f
https://hg.mozilla.org/mozilla-central/rev/2cc9b5cace93
https://hg.mozilla.org/mozilla-central/rev/b1246187a93d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/98ebc9d48936
https://hg.mozilla.org/releases/mozilla-beta/rev/f2187e0517bb
https://hg.mozilla.org/releases/mozilla-beta/rev/24f1807175a9
https://hg.mozilla.org/releases/mozilla-beta/rev/c137e55aed6e