Remove remaining callback-style functions in apz_test_native_event_utils.js
Categories
(Core :: Panning and Zooming, task)
Tracking
()
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(4 files)
After the changes in bug 1666295's dependencies, most of the APZ tests and helper functions have been migrated from callback-style to promise or async/await-style. There's a handful of functions left over in apz_test_native_event_utils that still take a callback function, and can be removed pretty easily. This bug will do that.
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
This function has only one caller, which was trivial to migrate.
Depends on D109245
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D109246
Assignee | ||
Comment 4•3 years ago
|
||
It was only used by the promise-style equivalent, so this folds the two together.
Depends on D109247
Assignee | ||
Comment 5•3 years ago
|
||
Everybody uses the promise-style equivalent so we can just move over
the documentation and drop the function.
Depends on D109248
Pushed by kgupta@mozilla.staktrace.com: https://hg.mozilla.org/integration/autoland/rev/34cbd820c7bd Convert synthesizeNativeWheelAndWaitForObserver from callback-style to promise-style. r=botond https://hg.mozilla.org/integration/autoland/rev/855b75b8db8f Remove synthesizeNativeWheelAndWaitForScrollEvent and migrate callers to promiseNativeWheelAndWaitForScrollEvent. r=botond https://hg.mozilla.org/integration/autoland/rev/2cc9b5cace93 Remove unused synthesizeNativeMouseEventWithAPZAndWaitForEvent function. r=botond https://hg.mozilla.org/integration/autoland/rev/b1246187a93d Remove unused moveMouseAndScrollWheelOver function. r=botond
Comment 7•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/34cbd820c7bd
https://hg.mozilla.org/mozilla-central/rev/855b75b8db8f
https://hg.mozilla.org/mozilla-central/rev/2cc9b5cace93
https://hg.mozilla.org/mozilla-central/rev/b1246187a93d
Comment 8•3 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/98ebc9d48936
https://hg.mozilla.org/releases/mozilla-beta/rev/f2187e0517bb
https://hg.mozilla.org/releases/mozilla-beta/rev/24f1807175a9
https://hg.mozilla.org/releases/mozilla-beta/rev/c137e55aed6e
Description
•