1700076 - Clean up some DNS code

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Handle nsHostResolver::CancelAsyncRequest being called for records in the eviction queue r=#necko

The reason this worked previously is that we initialized recPtr = rec; in
the for loop iterating through callbacks.
Records that were in the evictionQ did not have any callbacks, so we never
entered this block.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Fix modernize-use-default-member-init clang-tidy warnings in netwerk/dns/ r=#necko

This patch consists of the changes generated by running
./mach static-analysis check --fix on netwerk/dns after adding the
modernize-use-default-member-init clang-tidy lint.
Some additional changes were made by hand to ensure consistent results.
This patch ensures that all member variables are initialized in the header,
so when adding or changing constructors we don't miss one resulting in
uninitialized memory.

Depends on D109338

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Allow nsHostResolver::FlushCache to clear Type records from the cache r=kershaw

Depends on D109339

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Add ability to count number of DoH requests that reach the TRRServer r=#necko

Depends on D109588

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Add ability to cancel TRR requests before they're dispatched r=#necko

A TRR request is created and dispatched to the handling thread.
If we want to cancel it, we may do so before the runnable has been handled
and there's no HTTP channel - so the cancel was a NO-OP.
Here we add mCancelled which is consulted in SendHTTPRequest to check
if the request has already been cancelled.

Depends on D109589

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Make TRRDNSListener handle for type records resolves r=#necko

Depends on D109590

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_httpssvc_priority.js r=#necko

Depends on D109591

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_httpssvc_https_upgrade.js r=#necko

Depends on D109592

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_httpssvc_iphint.js r=#necko

Depends on D109593

Comment 10

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_httpssvc_retry_with_ech.js r=#necko

Depends on D109594

Comment 11

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_httpssvc_retry_without_ech.js r=#necko

Depends on D109595

Comment 12

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_trr_https_fallback.js r=#necko

Depends on D109596

Comment 13

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_trr_httpssvc.js r=#necko

Depends on D109597

Comment 14

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up unit_ipc/test_dns_by_type_resolve_wrap.js r=#necko

Depends on D109598

Comment 15

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_dns_by_type_resolve.js r=#necko

Depends on D109599

Comment 16

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1700076 - Clean up test_http3_fast_fallback.js r=#necko

Depends on D109600

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb3f2329ca37
Handle nsHostResolver::CancelAsyncRequest being called for records in the eviction queue r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/f36e9cb05851
Fix modernize-use-default-member-init clang-tidy warnings in netwerk/dns/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/8dc21acb87f9
Allow nsHostResolver::FlushCache to clear Type records from the cache r=kershaw,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/26dc88b74377
Add ability to count number of DoH requests that reach the TRRServer r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/c085324cb20e
Add ability to cancel TRR requests before they're dispatched r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/016c856573da
Make TRRDNSListener handle for type records resolves r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/bc92b34e5d71
Clean up test_httpssvc_priority.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/2b8d8d63cacd
Clean up test_httpssvc_https_upgrade.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/776c44be95f5
Clean up test_httpssvc_iphint.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/1315c00d2137
Clean up test_httpssvc_retry_with_ech.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/753f4df63689
Clean up test_httpssvc_retry_without_ech.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/fcf27f3c7b69
Clean up test_trr_https_fallback.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/9bc2539a1f5d
Clean up test_trr_httpssvc.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/8094a7ffc6a4
Clean up unit_ipc/test_dns_by_type_resolve_wrap.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/fcf92dd5158a
Clean up test_dns_by_type_resolve.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/d89075d72c83
Clean up test_http3_fast_fallback.js r=necko-reviewers,kershaw

Comment 18

[Cosmin Sabou [:CosminS]]

Backed out for causing windows xpcshell failures on test_trr_cancel.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&fromchange=5f3eb0797c06ff38383e8fca88cbb6ed4038d02d&searchStr=xpc&tochange=dae7fefaf8278e53d864391a50ae947d5ce5747a&selectedTaskRun=QimLb7z6Rb62U1gM8yM-gQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=335595411&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/dae7fefaf8278e53d864391a50ae947d5ce5747a

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/050ea2cafe11
Handle nsHostResolver::CancelAsyncRequest being called for records in the eviction queue r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/8b18a2ef9994
Fix modernize-use-default-member-init clang-tidy warnings in netwerk/dns/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/5f509655c215
Allow nsHostResolver::FlushCache to clear Type records from the cache r=kershaw,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/60897816589a
Add ability to count number of DoH requests that reach the TRRServer r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/454a28c52dea
Add ability to cancel TRR requests before they're dispatched r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/932669e39fee
Make TRRDNSListener handle for type records resolves r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/de03852907a9
Clean up test_httpssvc_priority.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/5f229ee8e18e
Clean up test_httpssvc_https_upgrade.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/a613ba2c47ce
Clean up test_httpssvc_iphint.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/46d002eac860
Clean up test_httpssvc_retry_with_ech.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/966cdbee3d9a
Clean up test_httpssvc_retry_without_ech.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/4ae857f4eb1c
Clean up test_trr_https_fallback.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/831b2508adb8
Clean up test_trr_httpssvc.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/e72097442c6e
Clean up unit_ipc/test_dns_by_type_resolve_wrap.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/4d02b3bf9c38
Clean up test_dns_by_type_resolve.js r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/fcbcbedc28f4
Clean up test_http3_fast_fallback.js r=necko-reviewers,kershaw

Comment 20

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/050ea2cafe11
https://hg.mozilla.org/mozilla-central/rev/8b18a2ef9994
https://hg.mozilla.org/mozilla-central/rev/5f509655c215
https://hg.mozilla.org/mozilla-central/rev/60897816589a
https://hg.mozilla.org/mozilla-central/rev/454a28c52dea
https://hg.mozilla.org/mozilla-central/rev/932669e39fee
https://hg.mozilla.org/mozilla-central/rev/de03852907a9
https://hg.mozilla.org/mozilla-central/rev/5f229ee8e18e
https://hg.mozilla.org/mozilla-central/rev/a613ba2c47ce
https://hg.mozilla.org/mozilla-central/rev/46d002eac860
https://hg.mozilla.org/mozilla-central/rev/966cdbee3d9a
https://hg.mozilla.org/mozilla-central/rev/4ae857f4eb1c
https://hg.mozilla.org/mozilla-central/rev/831b2508adb8
https://hg.mozilla.org/mozilla-central/rev/e72097442c6e
https://hg.mozilla.org/mozilla-central/rev/4d02b3bf9c38
https://hg.mozilla.org/mozilla-central/rev/fcbcbedc28f4