1700079 - Use lazy getters to avoid loading Log.jsm / TelemetryController.jsm earlier than necessary from CrashManager.jsm

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Mark Banner (:standard8)]

Looking at a profile for Thunderbird, I noticed that CrashManager.jsm is doing two unnecessary things:

• Initialising a logging module, when it is only used for some warning messages.
• Loading TelemetryController.jsm via a direct import rather than a lazy loader. Making this lazy only delays loading of TelemetryController.jsm by a few ms, but means it is first loaded via TelemetryStartup, which seems more appropriate.

This won't save much in terms of time, maybe a little in memory.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1700079 - Use lazy getters in CrashManager.jsm to avoid loading/initialising items unnecessarily.

Comment 3

[Mark Banner (:standard8)]

Chris, in investigating this change Andrew noticed that this would mean TelemetryController.jsm is not loaded on Fenix (at least not during startup). It seems that TelemetryStartup.jsm is not fired there.

Do you know if that is expected / acceptable?

Comment 4

[Chris H-C :chutten]

Hm. I thought TelemetryController was already not being loaded in Fenix. Telemetry doesn't work in Fenix, it has Glean which is much better. This change brings reality more in line with my imagination, so I definitely approve : )

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e41fd0c1f392
Use lazy getters in CrashManager.jsm to avoid loading/initialising items unnecessarily. r=florian

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e41fd0c1f392