1700106 - Remove eslint specific for devtool's mochitests

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Alexandre Poirot [:ochameau]]

DevTools mochitests are running with some specific config:
https://searchfox.org/mozilla-central/source/devtools/.eslintrc.mochitests.js#10-33

Some rules like JSX looks pure legacy and can be removed
and many others looks like things that should be addressed instead of being workaround via a custom rule.

Comment 1

[Alexandre Poirot [:ochameau]]

Bug 1564431 would have helped making the following pattern matching work:
https://searchfox.org/mozilla-central/source/.eslintrc.js#26

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Remove all unused eslint rules from devtools mochitests.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Remove the gDevTools custom eslint global from DevTools mochitests.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Remove the waitUntilState custom eslint global from DevTools mochitests.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Remove the waitForTick custom eslint global from DevTools mochitests.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Remove the balanced-observers eslint disabling from DevTools mochitests.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Exclude tests from general reject-some-requires eslint rule.

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Exclude tests from general DevTools camelcase eslint rule.

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Remove now-useless eslint files related to mochitests.

I kept a few having some overrides. But they may be irrelevant.
And I kept some eslint files for all folder that aren't matching the pattern matching "/test*//browser*/".
Ideally we would rename these folder to match.

Last but not least, I identified one case where we were using mochitest file for xpcshell tests!

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1700106 - [devtools] Removed synthesizeKeyFromKeyTag unused test helper.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeb59dd8939f
[devtools] Remove all unused eslint rules from devtools mochitests. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/039a01c906b0
[devtools] Remove the gDevTools custom eslint global from DevTools mochitests. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/bab0a5372c7f
[devtools] Remove the waitUntilState custom eslint global from DevTools mochitests. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/34bdea224bf1
[devtools] Remove the waitForTick custom eslint global from DevTools mochitests. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/7582b10727ee
[devtools] Remove the balanced-observers eslint disabling from DevTools mochitests. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/a6cba7972cd7
[devtools] Exclude tests from general reject-some-requires eslint rule. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/ab0345c22e40
[devtools] Exclude tests from general DevTools camelcase eslint rule. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/13af1d6187c5
[devtools] Remove now-useless eslint files related to mochitests. r=jdescottes,Standard8
https://hg.mozilla.org/integration/autoland/rev/a667260c7e49
[devtools] Removed synthesizeKeyFromKeyTag unused test helper. r=jdescottes

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/eeb59dd8939f
https://hg.mozilla.org/mozilla-central/rev/039a01c906b0
https://hg.mozilla.org/mozilla-central/rev/bab0a5372c7f
https://hg.mozilla.org/mozilla-central/rev/34bdea224bf1
https://hg.mozilla.org/mozilla-central/rev/7582b10727ee
https://hg.mozilla.org/mozilla-central/rev/a6cba7972cd7
https://hg.mozilla.org/mozilla-central/rev/ab0345c22e40
https://hg.mozilla.org/mozilla-central/rev/13af1d6187c5
https://hg.mozilla.org/mozilla-central/rev/a667260c7e49