1700136 - [Proton] Hover state for close icon in infobars is too large

Status: RESOLVED WONTFIX

(Toolkit :: General, defect, P2)

Description

[Sören Hentzschel]

Attachment: screenshot

The close icon for infobars, for example for blocked pop-ups, is too large. It uses the full height and this doesn't fit other parts of the design.

Comment 1

[:Gijs (he/him)]

Blake, I think you're playing replacement Mark this week, can you prioritize this / pass this on as appropriate? Unsure what the spec says here.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

(Ta-da! Also, Mark's back tomorrow… 😉)

Comment 3

[Mark Striemer [:mstriemer]]

This has likely made it to release and is fixed in the next release with the proton styling. It definitely got bigger but I'm not convinced it wasn't intentional and I don't think it looks bad so not worth fixing in my opinion.

Comment 4

[Sören Hentzschel]

This is not fixed for all infobars. One example is the translation bar that is used by the Mozilla Bergamot extension. Another example is the notification bar if the Widevine CDM is not yet installed. Maybe there are other cases as well but these are the two cases I know.

I am pretty sure that the close icon as it can be seen in the screenshot is not intentional because it does not match any other close icon in Firefox. It never takes the full height of the parent element.

I set a needinfo? request to you just that you're aware that there are still cases. Maybe these cases are not important enough to fix it for Firefox 89 but maybe this ticket should be re-opened and the issue be fixed afterwards?

Comment 5

[Mark Striemer [:mstriemer]]

The bergamot infobar was out of scope for proton, Bug 1703322 is on file to update it to the proton styling. It's quite custom so looked like it would be a decent amount of extra work

I disabled DRM and went to Netflix, the infobar saying DRM is required looked proton styled to me. After enabling DRM and the plugin not yet installed it also looked correct. Is there some other infobar that you're seeing this on? Do you have a screenshot?

Comment 6

[Sören Hentzschel]

Clearing an old needinfo request.

It seems that neither the pop-up blocker nor the Widevine notifications are still affected. Firefox Translations is still affected by this styling issue but as far as I understood a new interface for Firefox Translations is planned.