1700184 - Bump builtin addon version to make reflect the small changes applied in Bug 1698158

Status: RESOLVED FIXED

(WebExtensions :: General, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

While briefly discussing with Thomas Wisniewski about follow ups to Bug 1698158 we did notice that in Bug 1698158 we didn't bump the builtin addon versions for the addons we applied small tweaks on

I briefly discussed about this with Shane and Shane did also agree with me that it would be good to bump the versions for the addons we have changed as a general good practice when a builtin addon is being changed (at least bumping it once during that Nightly cycle), even if not doing so shouldn't be triggering any particular issue for those built in addons and the fact that (besides the fix for the report-site-issues issue described in Bug 1697404) all changes were just cleanups for unnecessary imports and so the old and new versions of those files are basically functionally the same).

Looking to the history of the builtin addons' manifest.json files, it looks that:

• it did actually happened pretty often for some of the builtin addons (e.g. formautofill manifest has never been changed from '28 Jul 2018' but its api.js file has been updated quite some time from that date) but some of them have been bumped more or less regularly (e.g. webcompat seems to be one of those).
• pictureinpicture builtin addon seems to have been added in Firefox 88 and so we may just skip it (and also skip the addons that have been changed in Bug 1698158 but only used in the test harnesses).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1700184 - Bump report-site-issue version and remove redundant Services definition from aboutConfigPrefs.js API. r?twisniewski!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1700184 - Bump formautofill builtin addon version.

Depends on D109394

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1700184 - Bump screenshots builtin addon version.

Depends on D109395

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1700184 - Bump webcompat builtin addon version. r?twisniewski!

Depends on D109396

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4ac52593f2e
Bump report-site-issue version and remove redundant Services definition from aboutConfigPrefs.js API. r=twisniewski,webcompat-reviewers
https://hg.mozilla.org/integration/autoland/rev/1fc2d71ba21c
Bump formautofill builtin addon version. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/b48692ff9385
Bump screenshots builtin addon version. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/2944365f6a2e
Bump webcompat builtin addon version. r=twisniewski,webcompat-reviewers

Comment 6

[Dorel Luca [:dluca]]

Backed out 4 changesets (bug 1700184) for Browser-chrome failures in formautofill/test/browser/browser_check_installed.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=334974667&repo=autoland&lineNumber=2398

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=2944365f6a2e6389d19a5de6bfd12fe542f66ec2

Backout:
https://hg.mozilla.org/integration/autoland/rev/2c2845fb9b974b08a46397eab130df7c54fb1db4

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

The failure was due to a formautofill test that is asserting the version of the formautofill extension.
I've updated D109395 to also bump the asserted version, and pushed to try to double-check that there aren't other tests that are doing something similar for the other builtin extension versions that are bumped in the attached patches.

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

None of the "oranges" in the last push to try seems to be related to the changes in the attached patches.

I'm going to push them to autoland again asap.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2feb427ded1b
Bump report-site-issue version and remove redundant Services definition from aboutConfigPrefs.js API. r=twisniewski,webcompat-reviewers
https://hg.mozilla.org/integration/autoland/rev/aa33a57676a1
Bump formautofill builtin addon version. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/8592aa135bdb
Bump screenshots builtin addon version. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/00bb64737312
Bump webcompat builtin addon version. r=twisniewski,webcompat-reviewers

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2feb427ded1b
https://hg.mozilla.org/mozilla-central/rev/aa33a57676a1
https://hg.mozilla.org/mozilla-central/rev/8592aa135bdb
https://hg.mozilla.org/mozilla-central/rev/00bb64737312