Official branding is missing in the import report detail page
Categories
(Firefox :: about:logins, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox86 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | + | verified |
firefox89 | + | verified |
People
(Reporter: tgiles, Assigned: tgiles)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
The "Firefox Lockwise" branding is missing when a user opens up the detailed Import Summary after importing some logins via CSV.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Comment 2•4 years ago
|
||
[Tracking Requested - why for this release]: Incorrect branding on this login import summary page - it should match about:logins and use the lockwise logo.
:tgiles, we should request uplift for this once that patch is ready.
Comment 4•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9211029 [details]
Bug 1700201 - Fix branding on csv detail import report page. r=sfoster
Beta/Release Uplift Approval Request
- User impact if declined: User may be confused when inspecting the detailed report after importing their logins via CSV since there is currently a lack of official branding on the report page.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This patch only affects the branding on the CSV import report page and does not functionally affect the report page or the CSV import feature.
- String changes made/needed:
Comment 6•4 years ago
|
||
I have verified this issue using the latest Firefox Nightly 89.0a1 (Build ID: 20210324160546) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.
- The "Firefox Lockwise" branding is displayed on the “Import Summary Report” page.
Comment 7•4 years ago
|
||
Comment on attachment 9211029 [details]
Bug 1700201 - Fix branding on csv detail import report page. r=sfoster
Approved for 88.0b3.
Comment 8•4 years ago
|
||
bugherder uplift |
Comment 9•4 years ago
|
||
I have verified this issue using the Firefox Beta 88.0b3 (Build ID: 20210325185929) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.
- The "Firefox Lockwise" branding is displayed on the “Import Summary Report” page.
Updated•4 years ago
|
Description
•