Closed Bug 1700201 Opened 4 years ago Closed 4 years ago

Official branding is missing in the import report detail page

Categories

(Firefox :: about:logins, defect, P2)

defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 + verified
firefox89 + verified

People

(Reporter: tgiles, Assigned: tgiles)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

The "Firefox Lockwise" branding is missing when a user opens up the detailed Import Summary after importing some logins via CSV.

Assignee: nobody → tgiles
Severity: -- → S4
Priority: -- → P2

[Tracking Requested - why for this release]: Incorrect branding on this login import summary page - it should match about:logins and use the lockwise logo.

:tgiles, we should request uplift for this once that patch is ready.

Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/793f6e2331ae Fix branding on csv detail import report page. r=sfoster
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Comment on attachment 9211029 [details]
Bug 1700201 - Fix branding on csv detail import report page. r=sfoster

Beta/Release Uplift Approval Request

  • User impact if declined: User may be confused when inspecting the detailed report after importing their logins via CSV since there is currently a lack of official branding on the report page.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch only affects the branding on the CSV import report page and does not functionally affect the report page or the CSV import feature.
  • String changes made/needed:
Attachment #9211029 - Flags: approval-mozilla-beta?

I have verified this issue using the latest Firefox Nightly 89.0a1 (Build ID: 20210324160546) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

  • The "Firefox Lockwise" branding is displayed on the “Import Summary Report” page.
Status: RESOLVED → VERIFIED

Comment on attachment 9211029 [details]
Bug 1700201 - Fix branding on csv detail import report page. r=sfoster

Approved for 88.0b3.

Attachment #9211029 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this issue using the Firefox Beta 88.0b3 (Build ID: 20210325185929) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

  • The "Firefox Lockwise" branding is displayed on the “Import Summary Report” page.
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: