1700201 - Official branding is missing in the import report detail page

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Tim Giles [:tgiles]]

The "Firefox Lockwise" branding is missing when a user opens up the detailed Import Summary after importing some logins via CSV.

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1700201 - Fix branding on csv detail import report page. r=sfoster

Comment 2

[Sam Foster [:sfoster] (he/him)]

[Tracking Requested - why for this release]: Incorrect branding on this login import summary page - it should match about:logins and use the lockwise logo.

:tgiles, we should request uplift for this once that patch is ready.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/793f6e2331ae
Fix branding on csv detail import report page. r=sfoster

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/793f6e2331ae

Comment 5

[Tim Giles [:tgiles]]

Comment on attachment 9211029 [details]
Bug 1700201 - Fix branding on csv detail import report page. r=sfoster

Beta/Release Uplift Approval Request

• User impact if declined: User may be confused when inspecting the detailed report after importing their logins via CSV since there is currently a lack of official branding on the report page.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only affects the branding on the CSV import report page and does not functionally affect the report page or the CSV import feature.
• String changes made/needed:

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 89.0a1 (Build ID: 20210324160546) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The "Firefox Lockwise" branding is displayed on the “Import Summary Report” page.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9211029 [details]
Bug 1700201 - Fix branding on csv detail import report page. r=sfoster

Approved for 88.0b3.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e71785ab0f7e

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the Firefox Beta 88.0b3 (Build ID: 20210325185929) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The "Firefox Lockwise" branding is displayed on the “Import Summary Report” page.