1700206 - sw-wr: non-native radio buttons on wiki.mozilla.org have white vertical and horizontal seams

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: wiki_radio_buttons_screenshot.jpg

Steps to reproduce

1. Set gfx.webrender.software = true and widget.non-native-theme.enabled = true (which is already the default in 88 Nightly) and restart Nightly.
2. Load https://wiki.mozilla.org/index.php?title=Main_Page&action=history. You don't need a wiki account.
3. Look at the radio buttons in the "Compare selected revisions" list.

Expected result

The radio buttons should not have any seams.

Actual result

The radio buttons on wiki.mozilla.org have white vertical and horizontal seams. See the attached screenshot.

Curiously, the radio buttons on Wikipedia don't have the seams. Perhaps wiki.mozilla.org styles its radio buttons differently?

https://en.wikipedia.org/w/index.php?title=Mozilla&action=history

Comment 1

[Chris Peterson [:cpeterson]]

Harry, I believe your fix for Proton bug 1696469 caused this radio button bug when using Software WebRender. I bisected this regression to the following pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4d4bc56f77a199234c625dfdd85d06c62caae273&tochange=fa6296b812008dfdde11078acba9142c687f85aa

Comment 2

[Emilio Cobos Álvarez (:emilio)]

That seems like a very unlikely regression range. I came up with a range which included https://hg.mozilla.org/mozilla-central/rev/2d0e67c944f238704125182f0c7006895a39bd86, which sounds about right.

We use borders to render circles, like we do for list bullets (via this code). It seems only SW-WR has issues with them, at some zoom levels. This probably affects other web content too, so while it can be worked around by setting widget.non-native-theme.webrender=false, we should probably get it fixed in sw-wr.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

a webcontent test case for this would be helpful.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: testcase

This shows the issue for me at some zoom levels. A bit less pronounced than in the radio control case though.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

That seems like a very unlikely regression range. I came up with a range which included https://hg.mozilla.org/mozilla-central/rev/2d0e67c944f238704125182f0c7006895a39bd86, which sounds about right.

Thanks. In that case, I will clear the needinfo for Harry.

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Bug 1700206 - Support tile repeat limits in SWGL. r?jrmuizel

Sometimes we sample slightly outside the tile repeat boundaries due to rounding
or anti-aliasing, which may cause potential sampling artifacts along primitive
edges. This adds supports for enforcing tile repeat limits as we otherwise do
in the brush_image shader to prevent such artifacts.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d90ccb089550
Support tile repeat limits in SWGL. r=jrmuizel

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d90ccb089550

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Would it be possible to land a test for this?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

nvm, I see that's covered by the comment in Phabricator

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Works great here now.

Comment 12

[Lee Salzman [:lsalzman]]

Comment on attachment 9212792 [details]
Bug 1700206 - Support tile repeat limits in SWGL. r?jrmuizel

Beta/Release Uplift Approval Request

• User impact if declined: Visual artifacts on SW-WR with non-native theming, and possibly on web content with repeating backgrounds.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change only affects SW-WR rollout in 88, and should only impact this particular corner-case.
• String changes made/needed:

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9212792 [details]
Bug 1700206 - Support tile repeat limits in SWGL. r?jrmuizel

Approved for 88.0b7.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cd4db3066b90