Feed subscribe dialog generates item.properties errors
Categories
(SeaMonkey :: MailNews: Account Configuration, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.7)
Attachments
(1 file, 1 obsolete file)
|
1.09 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
When the Subscribe dialog is open for feeds the error console shows lots of messages about TypeError: item.properties is undefined
Simple fix
|
||
Updated•5 years ago
|
|
|
||
Comment 2•5 years ago
•
|
||
Comment on attachment 9210873 [details] [diff] [review]
1700218-feed-sub-2537.patch
LGTM for SeaMonkey 2.53 and 2.57 release branches
This is probably a better fix, as until SM implements favicons for feeds image.properties will not exist.
|
|
||
Comment 4•5 years ago
•
|
||
Comment on attachment 9210910 [details] [diff] [review]
1700218-feed-sub-v1_1-2537.patch
yes makes more sense. As discussed over irc !item.properties should be first checked to bailout early.
- if ((item.folder && item.folder.isServer) || item.open)
+ if (!item.properties ||
+ (item.folder && item.folder.isServer) || item.open)
r/a+ for SeaMonkey 2.53 and 2.57 release branches.
|
|
||
Updated•5 years ago
|
|
|
||
Comment 5•5 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/2abee2cb77cff6d6639d75bde3b88a73d54eb8b0
Feed subscribe dialog generates item.properties errors. r=frg a=frg
|
||
Updated•1 year ago
|
Description
•