1700226 - Unreadable texts and menus when Big Sur Dark Mode is enabled

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect, P3)

Description

[João Gomes]

Attachment: Screenshot 2021-03-22 at 22.06.58.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_2_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36

Steps to reproduce:

Open Firefox and navigated to Gmail (or any other white page) on a Mac with Big Sur installed and the dark mode enabled.

Actual results:

Some texts in the page are not readable (specially web controls, like text boxes, dropdowns, etc.).
Most firefox context menus, and some other menus, are not readable (see prints).

Expected results:

All Firefox menu texts and web control texts should be readable, like it would happen with any other browser in this same platform.

Comment 1

[João Gomes]

Attachment: Screenshot 2021-03-22 at 22.08.57.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Francesco Lodolo [:flod]]

Which theme are you using? I don't see any issue with the same configuration, so I assume it's coming from a custom them.

Comment 4

[Andrei Purice]

Hey João,
I tried reproducing this issue on the latest versions of Firefox Nightly 89.0a1 (2021-03-23), beta 88.0b1 or release 87.0 switching between lighter themes but the elements are all perfectly visible for me.

Can you test the issue while in Safe Mode? You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .
If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Comment 5

[João Gomes]

Attachment: Theme

Comment 6

[João Gomes]

Attachment: confirmation_dialog.png

Comment 7

[João Gomes]

(In reply to Francesco Lodolo [:flod] from comment #3)

Which theme are you using? I don't see any issue with the same configuration, so I assume it's coming from a custom them.

Hi Francesco, thanks for your reply.
Please correct me if I'm wrong but I think that's the default theme that comes with Firefox.
I've attached some more screenshots that I think that may help. I've also attached some screen shots about my OS settings. Hope that helps

Comment 8

[João Gomes]

Attachment: os_settings.png

Comment 9

[João Gomes]

(In reply to Andrei Purice from comment #4)

Hey João,
I tried reproducing this issue on the latest versions of Firefox Nightly 89.0a1 (2021-03-23), beta 88.0b1 or release 87.0 switching between lighter themes but the elements are all perfectly visible for me.

Can you test the issue while in Safe Mode? You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .
If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Hey Andrei,
Many thanks for your reply :)
As you suggested I've created a fresh new profile (with no extensions or themes) logged in to gmail and took a new screenshot, and the issue remains (please see the last attachment I've added).
I will try Nightly build soon and come back to you guys with more details.

Thanks for your help!

Comment 10

[João Gomes]

Attachment: in-a-fresh-new-profile.png

Comment 11

[João Gomes]

Hello again guys,

I had the opportunity to test the unstable versions of Firefox and here's what I found:

• FireFox Beta (88.0b4) - OK, unable to reproduce the issue
• Firefox Developer Edition - OK, unable to reproduce the issue
• Firefox Nightly Edition - OK, unable to reproduce the issue
  • This version is one that has the best presentation, since it keeps the transparency / blur effect in the menus (that is present in the stable version)

Many thanks for your help guys, if you still need me to test anything else, please let me know.

Comment 12

[Albert Scheiner [:alberts]]

possibly a dup of bug 1703980

Comment 13

[Stephen A Pohl [:spohl] (OOO until 1/2)]

So to confirm, you are only able to reproduce this in Firefox Release? Have you manually disabled Aqua appearance for Firefox, either via Terminal or by switching the relevant key in the Info.plist file inside the Firefox.app bundle?

Comment 14

[João Gomes]

(In reply to Stephen A Pohl [:spohl] from comment #13)

So to confirm, you are only able to reproduce this in Firefox Release? Have you manually disabled Aqua appearance for Firefox, either via Terminal or by switching the relevant key in the Info.plist file inside the Firefox.app bundle?

Yes I was only able to reproduce in Firefox stable release. I have not changed any Firefox setting in order to try to fix the issue. I can try it, if you need me to.

Comment 15

[Stephen A Pohl [:spohl] (OOO until 1/2)]

Could you check your Firefox.app/Contents/Info.plist file and ensure that this key is set properly:

<key>NSRequiresAquaSystemAppearance</key>
<true/>

If that's the case, can you run the following command to see if anything is set?

defaults read org.mozilla.firefox NSRequiresAquaSystemAppearance

Comment 16

[João Gomes]

Ok the key (in Firefox.app/Contents/Info.plist file) is set as:

    <key>NSRequiresAquaSystemAppearance</key>
    <false/>

Here's the output of defaults read org.mozilla.firefox NSRequiresAquaSystemAppearance:

2021-04-19 17:10:38.031 defaults[49277:3015124]
The domain/default pair of (org.mozilla.firefox, NSRequiresAquaSystemAppearance) does not exist

Also, I've updated Firefox to version 88.0 and now all the menus and text boxes are readable, but the black theme is not being applied (as specified in Mac OS general settings), in other words, the background of context menus and dialog boxes now appear in blurred translucent light gray (don't know if this is the intended behavior, but, at least, now the text is readable :) )

Comment 17

[Stephen A Pohl [:spohl] (OOO until 1/2)]

Great to hear!

Respecting dark mode in context menus is tracked in bug 34572.
Respecting dark mode in dialogs and popups is tracked in bug 1623686.

Please feel free to follow progress by subscribing to those two bugs.

Closing this bug as Resolved/Worksforme.