1700292 - Marks not available for horizontal scrollbar, i.e. pages with `writing-mode: vertical-lr`

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P3)

Description

[Hector Zhao [:hectorz]]

Attachment: Screenshot of finding "ᠮᠣᠩ᠋ᠭᠣᠯ" in https://president.mn/mng/?p=4314

As can be seen in the attached screenshot.

Comment 1

[Neil Deakin]

Doesn't look like chrome supports this either. That said, it wouldn't be too hard to implement, but would involve quite a bit of changes to compute horizontal sizes instead of vertical:

Comment 2

[Hector Zhao [:hectorz]]

Attachment: Bug 1700292 - Draw scroll marks on horizontal scrollbar as well. r=emilio,jfkthame

Comment 3

[Hector Zhao [:hectorz]]

Attachment: Bug 1700292 - reftest for marks on horizontal scrollbar. r?#layout-reviewers

Depends on D139001

Comment 4

[Hector Zhao [:hectorz]]

Attachment: Screenshot of finding "ᠮᠣᠩ᠋ᠭᠣᠯ" in https://president.mn/mng/?p=4417

Hi, I've prepared a patch for this bug, which works for me locally.

One thing I'm not quite sure of: I thought it might be too busy to show marks on both horizontal and vertical scrollbars simultaneously, and opted to only display them on the one that has more space to scroll. I also never check for the page's writing mode, as originally mentioned in the bug's title.

I've added a reftest with two marks, that seems to work cross platforms (see treeherder)

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to Hector Zhao [:hectorz] from comment #4)

One thing I'm not quite sure of: I thought it might be too busy to show marks on both horizontal and vertical scrollbars simultaneously, and opted to only display them on the one that has more space to scroll. I also never check for the page's writing mode, as originally mentioned in the bug's title.

I agree that showing marks on both scrollbars is probably more confusing than helpful; but I'm inclined to think the choice should be based on the writing mode, rather than how much space there is. So the marks would always appear on the scrollbar that scrolls the content in its block-direction. Can you try that approach and see if it's workable?

Comment 6

[Hector Zhao [:hectorz]]

(In reply to Jonathan Kew (:jfkthame) from comment #5)

... but I'm inclined to think the choice should be based on the writing mode, rather than how much space there is. So the marks would always appear on the scrollbar that scrolls the content in its block-direction. Can you try that approach and see if it's workable?

I'll give it a try.

Comment 7

[Hector Zhao [:hectorz]]

Attachment: Bug 1700292 - Test to verify marks are set on the horizontal scrollbar for non-horizontal writing modes. r?jfkthame

Depends on D139002

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/331b8f5eb26f
Draw scroll marks on horizontal scrollbar as well. r=emilio,jfkthame
https://hg.mozilla.org/integration/autoland/rev/2508779c0651
reftest for marks on horizontal scrollbar. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/890de5447c2c
Test to verify marks are set on the horizontal scrollbar for non-horizontal writing modes. r=jfkthame

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/331b8f5eb26f
https://hg.mozilla.org/mozilla-central/rev/2508779c0651
https://hg.mozilla.org/mozilla-central/rev/890de5447c2c

Comment 10

[OUER]

It doesn't seem to work in this test case (https://bug1358017.bmoattachments.org/attachment.cgi?id=8961883).

Comment 11

[Jonathan Kew [:jfkthame]]

(In reply to OUER from comment #10)

It doesn't seem to work in this test case (https://bug1358017.bmoattachments.org/attachment.cgi?id=8961883).

I've filed bug 1757800 about this.