Closed
Bug 1700336
Opened 4 years ago
Closed 4 years ago
Use MaybeStorageBase in Maybe
Categories
(Core :: MFBT, task)
Core
MFBT
Tracking
()
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
References
Details
Attachments
(1 file)
Bug 1601556 extracted MaybeStorageBase from Maybe, which is now used in Result, but ought to be used in Maybe itself as well, to avoid duplication.
However, the draft patch doesn't work as intended on Windows (but not on Linux or OS X). It breaks the static_asserts on the sizes of Maybe<char> etc., so seemingly some padding is inserted. This requires some further work to fix that.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9210997 -
Attachment description: Bug 1700336 - WIP: Use MaybeStorageBase in Maybe. r=emilio → Bug 1700336 - Use MaybeStorageBase in Maybe. r=emilio
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dff6f2d5f806
Use MaybeStorageBase in Maybe. r=emilio
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•