Closed Bug 1700374 Opened 3 years ago Closed 3 years ago

[Proton] Address Bar Border flickers shortly when clicking into it, if the cursor was previously in NTP Search Bar

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
2

Tracking

()

VERIFIED FIXED
90 Branch
Iteration:
89.2 - Apr 5 - Apr 18
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: mehmet.sahin, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-address-bar] [priority:2b] [proton-uplift])

Attachments

(2 files)

Nightly 89.0a1 (2021-03-23) (64-Bit)
macOS 11.2.3

Steps to reproduce:
1.) Use System Dark Mode
2.) Enable Proton Address Bar
3.) Open a NTP
4.) Click into the NTP Address Bar
5.) Now click into the real Address Bar

Actual: A short flicker of the border appears.

Expected: No flicker of the border.

A screencast is attached.

Thanks.

This is probably an issue with the suppressFocusBorder attribute not keeping up with the actual focus state.

Severity: -- → S4
Points: --- → 2
Priority: -- → P2
Whiteboard: [proton-address-bar]
Whiteboard: [proton-address-bar] → [proton-address-bar] [priority:2b]
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Iteration: --- → 89.2 - Apr 5 - Apr 18
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/505b7fdbb498
Set suppress-focus-border true upon mouse down on urlbar while showing newtab page.r=harry

Backed out changeset 505b7fdbb498 (Bug 1700374) for causing bc failures in browser_suppressFocusBorder.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/b9adce06f3cf9a88dc5c1274f568b9a9149e2c52
Push with failures, failure log.

Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60a894f430c8
Set suppress-focus-border true upon mouse down on urlbar while showing newtab page.r=harry
Flags: needinfo?(daisuke)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(daisuke)

Comment on attachment 9216358 [details]
Bug 1700374: Set suppress-focus-border true upon mouse down on urlbar while showing newtab page.r?harry!

Beta/Release Uplift Approval Request

  • User impact if declined: It will be a bit of an eyesore on the address bar if Proton on.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: 1706112
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Because these changes are only some lines of JavaScript, and it affects only the user interaction on the address bar of Proton.
  • String changes made/needed:
Flags: needinfo?(daisuke)
Attachment #9216358 - Flags: approval-mozilla-beta?
Whiteboard: [proton-address-bar] [priority:2b] → [proton-address-bar] [priority:2b] [proton-uplift]

Daisuke, your patch doesn't graft cleanly to beta because it is based on changes you landed previously in bug 1706112. Should bug 1706112 be uplifted as well? if not, please provide a rebased patch for the beta branch, thanks!

Flags: needinfo?(daisuke)

Hello Pascal!
Ah, yes, I'd like to uplift bug 1706112 as well.
Is there anything I should do to uplift the patch??

Flags: needinfo?(daisuke) → needinfo?(pascalc)

(In reply to Daisuke Akatsuka (:daisuke) from comment #10)

Hello Pascal!
Ah, yes, I'd like to uplift bug 1706112 as well.
Is there anything I should do to uplift the patch??

Just request the uplift in the other bug and edit your comment #8 to mention the other dependent uplift in the "List of other uplifts needed", thanks!

Flags: needinfo?(pascalc)

I have updated the comment #8.
Thanks!

Comment on attachment 9216358 [details]
Bug 1700374: Set suppress-focus-border true upon mouse down on urlbar while showing newtab page.r?harry!

Approved for 89 beta 6 (with bug 1706112), thanks.

Attachment #9216358 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I could no longer reproduce this issue using Fx 90.0b12 and Fx 91.0a1 on Windows 10 x64 and macOS 10.13.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: