1700398 - Support Rest in scalar replacement

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Iain Ireland [:iain]]

We implemented scalar replacement of arguments in bug 1688033. Rest is the more modern equivalent, and it might be worth looking into. In particular, optimizing foo(...rest) is very similar to optimizing foo.apply({}, arguments). (We might have to skip some arguments in cases like function foo(a, b, ...rest), but the number of formals is known and fixed, so that should be pretty straightforward.)

Scalar replacement of arrays already almost supports the code we generate in inlined functions, except for the SetArrayLength.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1700398 - Part 1: Recover MRest. r=iain!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1700398 - Part 2: Scalar replace rest arrays. r=iain!

Depends on D130483

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1700398 - Part 3: Support scalar replacement for rest arguments in construct calls. r=iain!

Depends on D130484

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed6099a0ae3c
Part 1: Recover MRest. r=iain
https://hg.mozilla.org/integration/autoland/rev/f4c2a72cad24
Part 2: Scalar replace rest arrays. r=iain
https://hg.mozilla.org/integration/autoland/rev/547b8858819c
Part 3: Support scalar replacement for rest arguments in construct calls. r=iain

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ed6099a0ae3c
https://hg.mozilla.org/mozilla-central/rev/f4c2a72cad24
https://hg.mozilla.org/mozilla-central/rev/547b8858819c