Closed Bug 1700412 Opened 2 months ago Closed 29 days ago

Refactor "signon.recipes.remoteRecipesEnabled" pref

Categories

(Toolkit :: Password Manager, task, P3)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: tgiles, Assigned: ukohasarah, Mentored)

Details

Attachments

(1 file)

Currently the remote recipes pref for password manager is "signon.recipes.remoteRecipesEnabled." This is not the convention used for our prefs, the pref should be updated to "signon.recipes.remoteRecipes.enabled".

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on
      Element/Matrix
      in the #introduction channel. They're there to help you get started.
    • You can also read the
      Developer Guide,
      which has answers to most development questions.
  3. Start working on this bug.
    • You will need to update the preference in modules/libpref/init/all.js and toolkit/components/passwordmgr/LoginHelper.jsm. Additionally you will need to migrate the old preference using a pattern in the migrateUI function. You must ensure that a user's previous value is not overwritten during this migration.
    • If you have any problems with this bug,
      please comment on this bug and set the needinfo flag for me.
      Also, you can find me and my teammates on the #lockwise-desktop channel on
      Element/Matrix
      most hours of most days.
  4. Build your change with mach build and test your change with
    mach test toolkit/components/passwordmgr/test/ --headless.
    Also check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch (including an automated test, if applicable) for review.
    Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch,
    I'll mark it for checkin or push it to autoland.
    Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next.
    Let me know what you're interested in and I can help you find your next contribution.
Mentor: tgiles
Severity: -- → N/A
Priority: -- → P3

Hi! Sarah here from Outreachy...
Can I have a go on this one?
Will appreciate any helpful tips too.
Thanks.

Flags: needinfo?(tgiles)

Hi Sarah, when I originally wrote this ticket, I thought it was a simple as changing the preference...but we would also need to migrate the preference which might be outside of scope for a good first bug. I'll do some research and update the bug, but I would suggest finding another bug.

Flags: needinfo?(tgiles)

Ok, Thanks Tim. Will do.

Assignee: nobody → ukohasarah
Status: NEW → ASSIGNED
Attachment #9215831 - Attachment description: WIP: Bug 1700412 - Refactor 'signon.recipes.remoteRecipesEnabled' pref to 'signon.recipes.remoteRecipes.enabled' r=tgiles → Bug 1700412 - Refactor 'signon.recipes.remoteRecipesEnabled' pref to 'signon.recipes.remoteRecipes.enabled' r=tgiles
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58c6bf8ac5cc
Refactor 'signon.recipes.remoteRecipesEnabled' pref to 'signon.recipes.remoteRecipes.enabled' r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.