1700412 - Refactor "signon.recipes.remoteRecipesEnabled" pref

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P3)

Description

[Tim Giles [:tgiles]]

Currently the remote recipes pref for password manager is "signon.recipes.remoteRecipesEnabled." This is not the convention used for our prefs, the pref should be updated to "signon.recipes.remoteRecipes.enabled".

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Developer Guide,
     which has answers to most development questions.
3. Start working on this bug.
   • You will need to update the preference in modules/libpref/init/all.js and toolkit/components/passwordmgr/LoginHelper.jsm. Additionally you will need to migrate the old preference using a pattern in the migrateUI function. You must ensure that a user's previous value is not overwritten during this migration.
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #lockwise-desktop channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and test your change with
   mach test toolkit/components/passwordmgr/test/ --headless.
   Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 1

[Sarah Ukoha]

Hi! Sarah here from Outreachy...
Can I have a go on this one?
Will appreciate any helpful tips too.
Thanks.

Comment 2

[Tim Giles [:tgiles]]

Hi Sarah, when I originally wrote this ticket, I thought it was a simple as changing the preference...but we would also need to migrate the preference which might be outside of scope for a good first bug. I'll do some research and update the bug, but I would suggest finding another bug.

Comment 3

[Sarah Ukoha]

Ok, Thanks Tim. Will do.

Comment 4

[Sarah Ukoha]

Attachment: Bug 1700412 - Refactor 'signon.recipes.remoteRecipesEnabled' pref to 'signon.recipes.remoteRecipes.enabled' r=tgiles

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58c6bf8ac5cc
Refactor 'signon.recipes.remoteRecipesEnabled' pref to 'signon.recipes.remoteRecipes.enabled' r=tgiles

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/58c6bf8ac5cc