1700416 - Fix problems with WPT test "scaley.html" that prevent it from passing in any browser

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Daniel Holbert [:dholbert]]

The WPT test "scaley.html" has a number of problems and fails in all browsers as a result.

It's relatively straightforward to fix it so that it passes & usefully tests what it intends to test, though. Filing this bug on doing that.

Comment 1

[Daniel Holbert [:dholbert]]

WPT.fyi link for this test:
https://wpt.fyi/results/css/css-transforms/scaley.html?label=master&label=experimental&aligned

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1700416: Fix problems with WPT test "scaley.html" that were preventing it from passing in any browser. r?TYLin

This test never would have passed anywhere, but now it will start passing.

Problems with the test that are fixed here (all of which were keeping this test
from passing):

• The descriptive text on the page was different ("box." vs "area"), between
  the testcase and reference case.
• The testcase had a margin on this text, for no clear reason.
• The reference case had a border around the scaled-up green div, whereas
  the testcase doesn't (making them mismatch by the size of that border).

And while I'm at it, I'm making minor edits...

• making the indentation more consistent.
• switching to the HTML5 standards-mode doctype (since the testcase isn't
  doing anything relevant to quirks-mode that would require a legacy doctype).
• removing the unused ".hidden" CSS rule from the reference case.

This makes the testcase and reference case more usefully diffable.

Comment 3

[Daniel Holbert [:dholbert]]

Try run: https://treeherder.mozilla.org/jobs?repo=try&revision=eb6edfa73d2b549c41e5f557037d51c74bbd2d17

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdf6fd937572
Fix problems with WPT test "scaley.html" that were preventing it from passing in any browser. r=TYLin

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28221 for changes under testing/web-platform/tests

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bdf6fd937572

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Daniel Holbert [:dholbert]]

The amended test passes in all browsers:

https://wpt.fyi/results/css/css-transforms/scaley.html?label=master&label=experimental&aligned