1700434 - (sw-wr-perf-text) Animations on goliath-entertainment.com are shaking with WebRender software enabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: whatWeDo.png

[Affected platforms]:
Platforms: Windows 8 / 8.1

[Preconditions]:
Reach about:config and set both gfx.webrender.enabled, gfx.webrender.software - true

[Steps to reproduce]:

1. Launch the Firefox browser.
2. Reach https://www.goliath-entertainment.com/ and scroll down to the What do we do? section

Expected Result:
The Animation for the flying elements should be smooth and without visual issues.

Actual Results:
Some animations from the website are shaking.

Comment 1

[Raluca Popovici, Desktop QA]

This bug is also reproducible on Windows 7 x64, AMD - RX 550 and Ubuntu 18x64, Intel(R) HD Graphics 630.

Additional notes: The scroll on this site is not smooth with Webrender Software. With WebRender off and default WebRender the scroll is smooth.

Comment 2

[Lee Salzman [:lsalzman]]

This case is both dependent on cs_clip_image performance and ps_text_run in equal measure. But since it's a good example of a lot of big animated text all over the place, I'll let this serve as a slow-text metabug, while we already have one for cs_clip_image.

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1700434 - Implement faster subpixel text blend mode for SWGL. r?jrmuizel

This adds a swgl_blendSubpixelText() extension that enables us to move some
of the complexity of plumbing dual-source blending out of the shader for
subpixel text. This will enable further speed-ups later by allowing us to use
swgl_commitTexture.

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1700434 - Implement gl_ClipDistance support in SWGL. r?jrmuizel

This implements gl_ClipDistance so that the text shader doesn't have
to manually evaluate whether or not we're inside the untransformed
source texture. This simplification is necessary so that we can work
towards using swgl_commitTexture in the text shader.

Depends on D115456

Comment 5

[Lee Salzman [:lsalzman]]

Attachment: Bug 1700434 - Store mono bitmaps and alpha glyphs with same texture format. r?jrmuizel

Depends on D115457

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Bug 1700434 - Add SWGL fast-path for ps_text_run. r?jrmuizel

This adds some swgl_commitTextureLinearR8ToRGBA8 variations so that we can deal
with alpha glyph formats. Following that, a simple span shader is added that
dispatches to this as appropriate.

Depends on D115511

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ff6e9101b77
Implement faster subpixel text blend mode for SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/9d932ee247a2
Implement gl_ClipDistance support in SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/eb02c32b173e
Store mono bitmaps and alpha glyphs with same texture format. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/78cc8dd9ed2a
Add SWGL fast-path for ps_text_run. r=jrmuizel

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0412536f65c
Backed out 4 changesets for causing bustages in src/glsl.h

Comment 9

[Alexandru Michis [:malexandru]]

Backed out 4 changesets (Bug 1700434) for causing bustages in src/glsl.h
Backout link: https://hg.mozilla.org/integration/autoland/rev/e0412536f65c8583ae3708705c4c10a7f2fc5c49
Push with failures, failure log.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a998658f3364
Implement faster subpixel text blend mode for SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6643c36ec306
Implement gl_ClipDistance support in SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/64f8b849e94e
Store mono bitmaps and alpha glyphs with same texture format. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/215ea9dc277b
Add SWGL fast-path for ps_text_run. r=jrmuizel

Comment 11

[Iulian Moraru]

Backed out for causing bustages in src/glsl.h.

Push with failures

Failure log

Backout link

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68ac30edfcb6
Implement faster subpixel text blend mode for SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0b6d62c5e8ff
Implement gl_ClipDistance support in SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0a38ce1f4c59
Store mono bitmaps and alpha glyphs with same texture format. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/e53af9e245db
Add SWGL fast-path for ps_text_run. r=jrmuizel

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/68ac30edfcb6
https://hg.mozilla.org/mozilla-central/rev/0b6d62c5e8ff
https://hg.mozilla.org/mozilla-central/rev/0a38ce1f4c59
https://hg.mozilla.org/mozilla-central/rev/e53af9e245db

Comment 14

[Rares Doghi, Desktop QA]

Hi Jeff and Lee, the issue still occurs in our latest Nightly build 90.0a1 (2021-05-23), The art direction sign is shaking a lot less than before but it still happens for a bit, as for the text on the right side, that is just as bad as before, the letters are shaking individually, as for the browser on the right you can see the art direction sign is not shaking at all and neither are the letters in the top right corner.

The video file is a little larger than I'm allowed to upload here because I had to record with my phone but I hope the link from the gmail drive works.
Left browser: software enabled Right browser: Webrender disabled
https://drive.google.com/file/d/1oF19SiR3VhzZ1hHZTWk3st9mxE_H8qWh/view?usp=sharing