1700443 - Remove old arguments analysis code

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Iain Ireland [:iain]]

Bug 1688033 rewrote the arguments analysis using escape analysis. That code will ride the trains in 89; once 90 opens, we should remove the old code.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Remove AnalyzeArgumentsUsage r=jandem

This patch removes the needsArgsAnalysis flag. Other flags will be cleaned up in a later patch.

Comment 2

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Remove argumentsOptimizationFailed r=jandem

Depends on D114032

Comment 3

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Clean up BaselineCodeGen r=jandem

The HAS_ARGS_OBJ flag in BaselineFrame needs to stick around for the baseline interpreter, but it's immutable for the baseline compiler. (The next patch will move needsArgsObj from MutableFlags to ImmutableFlags.)

Depends on D114033

Comment 4

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Simplify JSScript flags for arguments r=jandem

After the previous patches, JSScript still has three flags related to arguments analysis. Two of them are immutable (argumentsHasVarBinding and alwaysNeedsArgsObj), and one is mutable (needsArgsObj). We can simplify this down to just needsArgsObj, which is now immutable.

After the simplification, there's no longer any difference between argsObjAliasesFormals and argumentsAliasesFormals.

Depends on D114034

Comment 5

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Clean up CompileInfo r=jandem

Depends on D114035

Comment 6

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Remove dead CacheIR ops r=jandem

The next patch removes CallFlags::FunApplyMagicArgs.

Depends on D114036

Comment 7

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Remove FunApplyMagicArgs r=jandem

Depends on D114169

Comment 8

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Remove MIRType::MagicOptimizedArguments r=jandem!

Depends on D114170

Comment 9

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Clean up EnvironmentObject and Debugger r=jandem

There's a separate usecase here that overloaded JS_OPTIMIZED_ARGUMENTS. getMissingArgumentsMaybeSentinelValue returns JS_OPTIMIZED_ARGUMENTS if it can't recreate the arguments object. The comment on createMissingArguments explains that this occurs if the environment is dead; see tests/debug/Frame-eval-12.js, where we return an inner function that subsequently tries to access its parent's arguments. There's a bunch of code on the devtools side of the wall to handle this case, and we have test coverage, so instead of ripping this out I'm just rewriting it to use a different magic value.

Depends on D114171

Comment 10

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Clean up SetFrameArgumentsObject r=jandem

The only remaining caller of SetFrameArgumentsObject is FinishBailoutToBaseline.

Depends on D114172

Comment 11

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Remove AnalysisMode r=jandem

Depends on D114173

Comment 12

[Iain Ireland [:iain]]

Attachment: Bug 1700443: Remove JS_OPTIMIZED_ARGUMENTS r=jandem!

Depends on D114174

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce61dab689b9
Remove AnalyzeArgumentsUsage r=jandem
https://hg.mozilla.org/integration/autoland/rev/bf132d76a357
Remove argumentsOptimizationFailed r=jandem
https://hg.mozilla.org/integration/autoland/rev/c7784fbc5ac7
Clean up BaselineCodeGen r=jandem
https://hg.mozilla.org/integration/autoland/rev/2d6ddfca0a01
Simplify JSScript flags for arguments r=jandem
https://hg.mozilla.org/integration/autoland/rev/97a240f4593b
Clean up CompileInfo r=jandem
https://hg.mozilla.org/integration/autoland/rev/f0c3565b1841
Remove dead CacheIR ops r=jandem
https://hg.mozilla.org/integration/autoland/rev/de19cbf58624
Remove FunApplyMagicArgs r=jandem
https://hg.mozilla.org/integration/autoland/rev/1532bdab7a74
Remove MIRType::MagicOptimizedArguments r=jandem
https://hg.mozilla.org/integration/autoland/rev/43d61f75ce6f
Clean up EnvironmentObject and Debugger r=jandem
https://hg.mozilla.org/integration/autoland/rev/1738078ae073
Clean up SetFrameArgumentsObject r=jandem
https://hg.mozilla.org/integration/autoland/rev/e2cacd540779
Remove AnalysisMode r=jandem
https://hg.mozilla.org/integration/autoland/rev/11741e1b7f70
Remove JS_OPTIMIZED_ARGUMENTS r=jandem

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ce61dab689b9
https://hg.mozilla.org/mozilla-central/rev/bf132d76a357
https://hg.mozilla.org/mozilla-central/rev/c7784fbc5ac7
https://hg.mozilla.org/mozilla-central/rev/2d6ddfca0a01
https://hg.mozilla.org/mozilla-central/rev/97a240f4593b
https://hg.mozilla.org/mozilla-central/rev/f0c3565b1841
https://hg.mozilla.org/mozilla-central/rev/de19cbf58624
https://hg.mozilla.org/mozilla-central/rev/1532bdab7a74
https://hg.mozilla.org/mozilla-central/rev/43d61f75ce6f
https://hg.mozilla.org/mozilla-central/rev/1738078ae073
https://hg.mozilla.org/mozilla-central/rev/e2cacd540779
https://hg.mozilla.org/mozilla-central/rev/11741e1b7f70