Remove ::-moz-scrolled-page-sequence
Categories
(Core :: Printing: Output, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
|
Assignee | |
Comment 1•3 years ago
|
||
No behavior change, just compute the different things we need upfront.
At first I was going to use this in the following patch but it ended up
not being needed.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Drive-by fixup while I was reading related code.
Depends on D109545
|
|
Assignee | |
Comment 3•3 years ago
|
||
This is needed for bug 1700379, because otherwise we create a reference
frame with the root's scrolled content (the
::-moz-scrolled-page-sequence), and that breaks some display list
invariants.
Always create a canvas frame instead, (doesn't matter when printing
since we print off the page sequence frame directly), and create a
single ::-moz-page-sequence box.
|
||
Comment 4•3 years ago
|
||
(Note, the phabricator stack ordering here seems like it may be a bit messed up -- though maybe its current state is actually good, if you want to land parts 1 and 2 here ~right away, and then land part 3 after bug 1700379 is reviewed.)
|
|
Assignee | |
Comment 5•3 years ago
|
||
Yeah, I'll reorg the stack, thanks for the heads-up. These three patches are fine to land independently of the other bug.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/168b31448423 Minor cleanup in ConstructDocElementFrame. r=dholbert https://hg.mozilla.org/integration/autoland/rev/ec476bf43984 Add braces to SetPaginatedScrolling. r=dholbert https://hg.mozilla.org/integration/autoland/rev/df4d74e9669f Remove -moz-scrolled-page-sequence. r=dholbert
|
||
Comment 7•3 years ago
|
||
Backed out for causing reftest failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/802e9aa013297a5b856cda3647811e1d8497e553
Failure log: https://treeherder.mozilla.org/logviewer?job_id=334232208&repo=autoland&lineNumber=3892
|
|
Assignee | |
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b0c17b9e247 Minor cleanup in ConstructDocElementFrame. r=dholbert https://hg.mozilla.org/integration/autoland/rev/8986f83f55e9 Add braces to SetPaginatedScrolling. r=dholbert
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/73d7981be879 Remove -moz-scrolled-page-sequence. r=dholbert
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5b0c17b9e247
https://hg.mozilla.org/mozilla-central/rev/8986f83f55e9
https://hg.mozilla.org/mozilla-central/rev/73d7981be879
Description
•