1700472 - Remove ::-moz-scrolled-page-sequence

Status: RESOLVED FIXED

(Core :: Printing: Output, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1700472 - Minor cleanup in ConstructDocElementFrame. r=dholbert

No behavior change, just compute the different things we need upfront.
At first I was going to use this in the following patch but it ended up
not being needed.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1700472 - Add braces to SetPaginatedScrolling. r=dholbert

Drive-by fixup while I was reading related code.

Depends on D109545

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1700472 - Remove -moz-scrolled-page-sequence. r=dholbert

This is needed for bug 1700379, because otherwise we create a reference
frame with the root's scrolled content (the
::-moz-scrolled-page-sequence), and that breaks some display list
invariants.

Always create a canvas frame instead, (doesn't matter when printing
since we print off the page sequence frame directly), and create a
single ::-moz-page-sequence box.

Comment 4

[Daniel Holbert [:dholbert]]

(Note, the phabricator stack ordering here seems like it may be a bit messed up -- though maybe its current state is actually good, if you want to land parts 1 and 2 here ~right away, and then land part 3 after bug 1700379 is reviewed.)

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Yeah, I'll reorg the stack, thanks for the heads-up. These three patches are fine to land independently of the other bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/168b31448423
Minor cleanup in ConstructDocElementFrame. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/ec476bf43984
Add braces to SetPaginatedScrolling. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/df4d74e9669f
Remove -moz-scrolled-page-sequence. r=dholbert

Comment 7

[Atila Butkovits]

Backed out for causing reftest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/802e9aa013297a5b856cda3647811e1d8497e553

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&revision=df4d74e9669fb82a66746ea58f2216e88c7dbbf3&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cdebug%2Creftests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-windows10-64-qr%2Fdebug-reftest-swr-e10s%2Cr2&selectedTaskRun=XgiqAnjdTZGJQrU1frLQVg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=334232208&repo=autoland&lineNumber=3892

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b0c17b9e247
Minor cleanup in ConstructDocElementFrame. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/8986f83f55e9
Add braces to SetPaginatedScrolling. r=dholbert

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73d7981be879
Remove -moz-scrolled-page-sequence. r=dholbert

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5b0c17b9e247
https://hg.mozilla.org/mozilla-central/rev/8986f83f55e9
https://hg.mozilla.org/mozilla-central/rev/73d7981be879