1700506 - Perma comm/mail/test/browser/account/browser_actions.js | A promise chain failed to handle a rejection: Generating OTR private key failed: Error: Error: open requires a single argument - stack: reportKeyGenFailure@resource:///modules/OTRUI.jsm:213:11

Status: RESOLVED FIXED

(Chat Core :: Security: OTR, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=334222202&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IaCJPpY5SHGI62NF3CEILw/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Kai Engert (:KaiE:)]

This appears to be a regression from bug 1682101, but it's very confusing.
https://hg.mozilla.org/comm-central/rev/7a0a62f2aeea9ddb7c604b9e8b1cb2fb99a917d2

I don't see code that changes the behavior.
What happens it, we try a different number of times to find the correct library.

I see it only fails in optimized builds - debug builds work fine.

I cannot locally reproduce the failure reported on Treeherder.
I can reproduce a failure in a local build, but I get a different error
FAIL Uncaught exception - at resource://testing-common/mozmill/utils.jsm:72 - TimeoutError: Timeout waiting for popup to open, state=closed

My local failure is intermittent, sometimes works, sometimes fails - even after backing out the above commit !

Comment 2

[Kai Engert (:KaiE:)]

I found something. Try build running.

Comment 3

[Kai Engert (:KaiE:)]

The key generation needs a variable that the new code no longer set.
I probably have the fix.
Try running here:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=bcd51f0b03f451bf09cd0f80b929f765fbc33a07

It was a major distraction that I'm getting a completely different failure when trying to reproduce locally.

Comment 4

[Kai Engert (:KaiE:)]

Attachment: Bug 1700506 - Restore variable libotrPath when loading OTR library. r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/046f719e7d8c
Restore variable libotrPath when loading OTR library. r=mkmelin

Comment 6

[Kai Engert (:KaiE:)]

Comment on attachment 9211275 [details]
Bug 1700506 - Restore variable libotrPath when loading OTR library. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1682101
User impact if declined:
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Intermittent Failures Robot]

10 failures in 3967 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 10

Platform and build breakdown:

• linux64: 3
  • opt: 3
• linux64-shippable: 1
  • opt: 1
• windows10-64-shippable: 1
  • opt: 1
• windows7-32: 1
  • opt: 1
• windows7-32-shippable: 1
  • opt: 1
• windows10-64: 2
  • opt: 2
• macosx1014-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1700506&startday=2021-03-22&endday=2021-03-28&tree=all

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9211275 [details]
Bug 1700506 - Restore variable libotrPath when loading OTR library. r=mkmelin

[Triage Comment]
Approved for beta

Comment 9

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-beta/rev/026a472cf4b68f7b1cffa56057c4508be6fa30d8
88.0b2

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9211275 [details]
Bug 1700506 - Restore variable libotrPath when loading OTR library. r=mkmelin

[Triage Comment]
Approved for esr78

Comment 11

[Kai Engert (:KaiE:)]

78.9.1
https://hg.mozilla.org/releases/comm-esr78/rev/24c97fc5cd94fb4ffb8adbb9578a3b70bbb99bd8