1700517 - Address any high-contrast & forced-colors mode issues with Proton icons

Status: RESOLVED WORKSFORME

(Firefox :: Theme, task, P1)

Description

[Sam Foster [:sfoster] (he/him)]

We have some workarounds for HCM and forced-colors mode in our icon svg files which we need to ensure aren't regressed by the icon update. Specifically, the check.svg and check-partial.svg have a thin, almost-invisible stroke that causes those icons to be visible in a XUL tree, e.g. about:preferences search engine table

Comment 1

[Sam Foster [:sfoster] (he/him)]

check.svg

svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16" fill="context-fill" fill-opacity="context-fill-opacity">
  <path stroke="context-stroke none" stroke-width="0.5" d="M6.52,12.5a1,1,0,0,1-.705-.291l-3.52-3.5a1,1,0,1,1,1.41-1.418l2.812,2.8,5.774-5.793a1,1,0,0,1,1.416,1.412l-6.479,6.5A1,1,0,0,1,6.52,12.5Z"/>
</svg>

Note the stroke-width attribute.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: search-preferences-table.png

Here's screenshot of search preferences table in forced colors mode, showing the thin/faint stroke on the checkmark next to the youtube video search.

Comment 3

[:Gijs (he/him)]

Investigating whether there's anything left to do here.

Comment 4

[:Gijs (he/him)]

Selection of the checkmark'd rows in tree views in both about:sessionrestore and the prefs now use Highlight background colours, and the row's foreground colour for the checkmark, so the checkmark is visible in HCM. I think there's nothing else left to do here.