1700623 - Move collection of Session Storage for Session Store to parent process.

Status: RESOLVED FIXED

(Firefox :: Session Restore, task, P2)

Comment 1

[Andreas Farre [:farre]]

The idea here is to collect using BackgroundSessionStorageManager and also allow for putting data into the BackgroundSessionStorageManager. Doing these two things is needed for Fission Session Restore's collect and restore step respectively.

Comment 2

[Andreas Farre [:farre]]

Attachment: Part 1: Bug 1700623 - Add storagePrincipal to WindowGlobalParent. r=nika!,timhuang!

We use the storage principal to look up origin records in the
background session storage manager.

Comment 3

[Andreas Farre [:farre]]

Attachment: Part 2: Bug 1700623 - Pass the storage principal to SessionStorageManager::EnsureCache. r=asuth!

Depends on D111428

Comment 4

[Andreas Farre [:farre]]

Attachment: Part 3: Bug 1700623 - Used TabStateFlusher.flush to guarantee session store state. r=kashav!

Depends on D111429

Comment 5

[Andreas Farre [:farre]]

Attachment: Part 4: Bug 1700623 - Add js value conversion for Record. r=peterv!

Depends on D111430

Comment 6

[Andreas Farre [:farre]]

Attachment: Part 5: Bug 1700623 - Add helper to get OriginAttributes from PrincipalInfo. r=timhuang!

Depends on D111431

Comment 7

[Andreas Farre [:farre]]

Attachment: Part 6: Bug 1700623 - Add data querying to SessionStorageManager in parent process. r=nika!,asuth!

To collect session storage data for session store, we make it possible
to query the background session storage managar for data.

Depends on D111432

Comment 8

[Andreas Farre [:farre]]

Attachment: Part 7: Bug 1700623 - Make session storage session store work with Fission. r=nika!

Use the newly added session storage data getter to access the session
storage in the parent and store it in session store without a round
trip to content processes.

Depends on D111433

Comment 9

[Andreas Farre [:farre]]

Attachment: Part 8: Bug 1700623 - Switch to use empty document in iframe. r=kashav!

Before session store collection would actually force document creation
when collecting session storage data, but we don't do that
anymore. Instead we switch from using 'about:robots' as the iframe
document to an empty document to actually be able to get unload and
pagehide.

Depends on D111434

Comment 10

[Andreas Farre [:farre]]

Attachment: Part 9: Bug 1700623 - Notify main thread about storage updates periodically. r=nika,asuth

This is used to update session store storage contents continuously.

Depends on D111435

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cd0b7a269e5
Part 1: Bug 1700623 - Add storagePrincipal to WindowGlobalParent. r=nika,timhuang
https://hg.mozilla.org/integration/autoland/rev/26df421dac02
Part 2: Bug 1700623 - Pass the storage principal to SessionStorageManager::EnsureCache. r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/c13bdee1b526
Part 3: Bug 1700623 - Used TabStateFlusher.flush to guarantee session store state. r=kashav
https://hg.mozilla.org/integration/autoland/rev/88b4add342df
Part 4: Bug 1700623 - Add js value conversion for Record. r=peterv
https://hg.mozilla.org/integration/autoland/rev/513ea16be430
Part 5: Bug 1700623 - Add helper to get OriginAttributes from PrincipalInfo. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/a4e673640de5
Part 6: Bug 1700623 - Add data querying to SessionStorageManager in parent process. r=nika,dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/7ab483627a27
Part 7: Bug 1700623 - Make session storage session store work with Fission. r=nika
https://hg.mozilla.org/integration/autoland/rev/97c3add3b00a
Part 8: Bug 1700623 - Switch to use empty document in iframe. r=kashav
https://hg.mozilla.org/integration/autoland/rev/5eae296ad8b5
Part 9: Bug 1700623 - Notify main thread about storage updates periodically. r=asuth

Comment 12

[Alexandru Michis [:malexandru]]

Backed out 9 changesets (Bug 1700623) for causing bc failures in browser_history_menu.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/734a6b594d2170164e302f60c02883741a2a111d
Push with failures, failure log.

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9d30cff8f9d4
Backed out 9 changesets for causing bc failures in browser_history_menu.js a=backout

Comment 14

[Andreas Farre [:farre]]

Attachment: Part 10: Bug 1700623 - Wait for history navigation in browser_history_menu.js r=peterv!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1510375be438
Part 1: Bug 1700623 - Add storagePrincipal to WindowGlobalParent. r=nika,timhuang
https://hg.mozilla.org/integration/autoland/rev/83b757d9d82b
Part 2: Bug 1700623 - Pass the storage principal to SessionStorageManager::EnsureCache. r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/741a8b0a0773
Part 3: Bug 1700623 - Used TabStateFlusher.flush to guarantee session store state. r=kashav
https://hg.mozilla.org/integration/autoland/rev/4f967aad4863
Part 4: Bug 1700623 - Add js value conversion for Record. r=peterv
https://hg.mozilla.org/integration/autoland/rev/d94aef8bad70
Part 5: Bug 1700623 - Add helper to get OriginAttributes from PrincipalInfo. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/92f898311207
Part 6: Bug 1700623 - Add data querying to SessionStorageManager in parent process. r=nika,dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/ce5a3250a87f
Part 7: Bug 1700623 - Make session storage session store work with Fission. r=nika
https://hg.mozilla.org/integration/autoland/rev/f0fe8770fa5d
Part 8: Bug 1700623 - Switch to use empty document in iframe. r=kashav
https://hg.mozilla.org/integration/autoland/rev/08ec785e3c97
Part 9: Bug 1700623 - Notify main thread about storage updates periodically. r=asuth
https://hg.mozilla.org/integration/autoland/rev/51ac7ee1f56d
Part 10: Bug 1700623 - Wait for history navigation in browser_history_menu.js r=peterv

Comment 16

[Andreas Farre [:farre]]

Fixed failure, trying to land again.

Comment 17

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1510375be438
https://hg.mozilla.org/mozilla-central/rev/83b757d9d82b
https://hg.mozilla.org/mozilla-central/rev/741a8b0a0773
https://hg.mozilla.org/mozilla-central/rev/4f967aad4863
https://hg.mozilla.org/mozilla-central/rev/d94aef8bad70
https://hg.mozilla.org/mozilla-central/rev/92f898311207
https://hg.mozilla.org/mozilla-central/rev/ce5a3250a87f
https://hg.mozilla.org/mozilla-central/rev/f0fe8770fa5d
https://hg.mozilla.org/mozilla-central/rev/08ec785e3c97
https://hg.mozilla.org/mozilla-central/rev/51ac7ee1f56d