Closed Bug 1700645 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28213 - Reland "Create canvasFilter class and interface"

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28213 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28213
Details from upstream follow.

b'Aaron Krajeski <aaronhk@chromium.org>' wrote:

Reland "Create canvasFilter class and interface"

Using the NewCanvas2DAPI flag on an idl file caused MSAN failures because
that flag was not explicitly initialized on the WebPreferences
constructor. This CL solves that problem
https://chromium-review.googlesource.com/c/chromium/src/+/2783641
I'll also run this CL through the MSan bots to confirm.

This is a reland of 5d00b2d8b1b3a3431ce093a990524a8b25a2bcac
It was reverted here https://chromium-review.googlesource.com/c/chromium/src/+/2775779

Original change's description:

Create canvasFilter class and interface

Create a "mongo-db" like interface for filters. Implement blur, but only
blur.

Bug: 1169216
Change-Id: I0dc045fa70f0d1e443cf4f8ff53632056cca6924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2741994
Reviewed-by: Aaron Krajeski \<aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini \<fserb@chromium.org>
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Reviewed-by: Xida Chen \<xidachen@chromium.org>
Reviewed-by: Juanmi Huertas \<juanmihd@chromium.org>
Reviewed-by: Yi Xu \<yiyix@chromium.org>
Commit-Queue: Aaron Krajeski \<aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#864863}

Bug: 1169216
Change-Id: I6e5badf27d41f6dbdc1759ac518d502d1983ebd2

Reviewed-on: https://chromium-review.googlesource.com/2780336
WPT-Export-Revision: 9a9857d858dd9547025d0d5c89f0ea78ef273060

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 3

Chrome

OK : 2
FAIL: 3

Safari

OK : 2
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/manual/filters/canvas-filter-object-blur.html: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/shadows/2d.shadow.canvasfilter.blur.object.exceptions.html
Test exceptions on CanvasFilter() blur.object: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/shadows/2d.shadow.canvasfilter.object.html
Test CanvasFilter() object: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/358f32ec555a [wpt PR 28213] - Reland "Create canvasFilter class and interface", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.