1700655 - [Enhancement] Consider changing the size of the focus border for about:logins meatball menu options

Status: VERIFIED FIXED

(Toolkit :: Themes, enhancement)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: Screenshot 2021-03-24 04:58:02.png

[Versions]:

• Firefox Beta 88.0b2 (Build ID: 20210323190052)
• Firefox Nightly 89.0a1 (Build ID: 20210324084848)

[Platforms]:

• Windows 10
• Linux Mint 20
• macOS 10.15

[Prerequisites]:

• Have Firefox Beta 88/Nightly 89 open.

[Steps to reproduce]:

1. Navigate to “about:logins”.
2. Click the meatball menu button (“...”).
3. Use the Tab key to navigate the options of the menu.
4. Observe the border of a focused option.

[Proposed result]:

• The border does not exceed the limits of the menu option on the right and left.

[Current result]:

• The border exceeds the limits of the menu option on the right and left.

[Notes]:

• This behavior was introduced in Bug 1698355.
• Attached is a screenshot of the current behavior.

Comment 1

[Itiel]

Attachment: Bug 1700655 - Contain the menuitems buttons' outline inside the about:logins menu r?tgiles

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/143152b39979
Contain the menuitems buttons' outline inside the about:logins menu r=tgiles

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/143152b39979

Comment 4

[Maria Heres, inactive, contact Ecosystem QA]

We have verified that the focus border does not exceed the limits of the menu options using Firefox Nightly 89.0a1 (Build ID: 20210325085523) using Windows 10, Linux Mint 20 and macOS 11.1. As a result I am marking this as verified fixed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Seems like a safe patch to uplift to 88. Please nominate for approval if you agree :)

Comment 6

[Itiel]

Comment on attachment 9211354 [details]
Bug 1700655 - Contain the menuitems buttons' outline inside the about:logins menu r?tgiles

Beta/Release Uplift Approval Request

• User impact if declined: Keyboard navigation in the about:logins menu is displayed with outline that exceeds the menu itself.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple one line CSS fix which targets the menuitems in that menu alone
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9211354 [details]
Bug 1700655 - Contain the menuitems buttons' outline inside the about:logins menu r?tgiles

Approved for 88.0b6.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a809a5ddb8bc

Comment 9

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the focus border does not exceed the limits of the menu options using Firefox Beta 88.0b7 (Build ID: 20210404185932) using Windows 10, Linux Mint 20 and macOS 11.1.