1700685 - browser_editAddressDialog.js should not rely on the TestUtils.waitForCondition initial timer

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Florian Quèze [:florian]]

If I fix bug 1596165, browser_editAddressDialog.js becomes a high frequency intermittent failure (almost perma fail) on "Linux 18.04 x64 opt". I can't reproduce locally.

TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | Uncaught exception - Wait for label to be populated by the mutation observer - timed out after 50 tries.
TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | Test timed out -
TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | Found a unknown window with document URI: chrome://formautofill/content/editAddress.xhtml and title: Add New Address after previous test timed out -

I'm adding a 10ms setTimeout in the test to be able to land, but it would be nice to figure this out.

Comment 1

[Neil Deakin]

The comment in the patch for 1446164 suggests that this should be fixed. Can we close this bug?

Comment 2

[Eemeli Aro [:eemeli]]

Afraid not; the tests still use waitForCondition and are skipped in verify.