1700713 - No icons next to New Container Tab menu items in native menus

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Markus Stange [:mstange]]

In the native menus on macOS, under File -> New Container Tab, the different container items do not show an icon next to them.

This also affects the context menu of the new tab button, if native context menus are enabled.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1700713 - Support SVG context paint properties for native menu icons. r=emilio

The context paint properties are used by the "New Container Tab" container icons.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1700713 - Use list-style-image for container menu icons. r=#desktop-theme-reviewers

Our native menu code does not check for images which are set as the CSS
background-image of the menuitem's icon <image>. We only support list-style-image
on the menuitem itself, and the <menuitem image="..."> attribute.

Depends on D109823

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1700713 - Make aFromComputedStyle parameter a const pointer. r=emilio

Comment 4

[Phabricator Automation]

Comment on attachment 9211655 [details]
Bug 1700713 - Make aFromComputedStyle parameter a const pointer. r=emilio

Revision D109829 was moved to bug 1701121. Setting attachment 9211655 [details] to obsolete.

Comment 5

[Phabricator Automation]

Comment on attachment 9211649 [details]
Bug 1700713 - Support SVG context paint properties for native menu icons. r=emilio

Revision D109823 was moved to bug 1701121. Setting attachment 9211649 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb515ff14ee1
Use list-style-image for container menu icons. r=desktop-theme-reviewers,harry

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bb515ff14ee1

Comment 8

[Emil Ghitta, QA [:emilghitta]]

Reproduced the issue mentioned in comment 0 using Firefox 89.0a1 (build from 2021-03-24).

This issue is verified fixed using Firefox 89.0a1 (BuildId:20210414160838) on macOS 10.15 with native menus enabled.