170073 - Running checksetup without File::Temp installed results in error.

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Christian Reis]

In CVS HEAD, running checksetup without File::Temp installed results in error:

blackjesus% ./checksetup.pl 
Can't locate File/Temp.pm in @INC (@INC contains: /usr/lib/perl5/i386-linux
/usr/lib/perl5 /usr/lib/perl5/site_perl/i386-linux /usr/lib/perl5/site_perl .)
at Bugzilla/Config.pm line 95.
BEGIN failed--compilation aborted at Bugzilla/Config.pm line 95.
BEGIN failed--compilation aborted at ./checksetup.pl line 119.

It should be checked for, and be shown as a required package.

Comment 1

[Dave Miller [:justdave]]

One of the Tinderboxes is burning because of this....

http://tinderbox.mozilla.org/Bugzilla/

Comment 2

[Dave Miller [:justdave]]

Attachment: patch

This patch moves the loading of Bugzilla::Config to a spot after the version
checks are done, and uses "require" + "import" to load it instead of using
"use" so it gets done at runtime after the version checks are done instead of
at compile time.  Also adds a version check for File::Temp (which currently
uses "any" -- is there a specific minimum version we need?)

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 101029 [details] [diff] [review]
patch

r=bbaetz x2

In the long run, we'll want to have the module check stuff in a BEGIN block, so
taht we don't have to worry about all this stuff.

(In the longer run, Makefile.PL will do teh checks for us....)

Comment 4

[Dave Miller [:justdave]]

-> patch author

Comment 5

[Dave Miller [:justdave]]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.194; previous revision: 1.193
done