1700732 - Make native menus respect display:none user styles on menu items

Status: RESOLVED WONTFIX

(Core :: Widget: Cocoa, enhancement, P3)

Description

[Markus Stange [:mstange]]

This was brought up in bug 34572 comment 29: Some users have custom userChrome CSS in order to hide unneeded items in the page context menu, by setting display:none on the items. Native context menus do not observe these CSS declarations at the moment, so these items are now unexpectedly shown in native context menus.
It's probably easy enough to check the computed display style on the DOM nodes and make this work.

Comment 1

[Markus Stange [:mstange]]

Attachment: WIP: Bug 1700732 - DOES NOT WORK Respect display:none on menu and menuitem elements in native menus, but don't handle dynamic changes.

This is enough to make the userChrome use case in bug 1700732 work.
We rebuild menus whenever they're opened, so if front-end code starts relying on
the ability to use display:none, then dynamic changes will at least be respected
the next time the menu is opened.

Comment 2

[Markus Stange [:mstange]]

I gave this a shot but it looks harder than anticipated.

The problem is that the naive approach breaks dynamic changes to the hidden attribute. [hidden=true] sets display:none. When hidden=true is removed, our AttributeChanged mutation observer calls nsMenuX::ObserveAttributeChanged which checks the new visibility state synchronously during the observer. Querying the computed style at this point still shows cs->StyleDisplay()->mDisplay == StyleDisplay::None. So it looks like the style hasn't yet updated in response to the attribute change, and the item is still treated as hidden even though the hidden attribute has just been removed.

Since this is just a nice-to-have I am not planning to spend more time on it.

Comment 3

[Markus Stange [:mstange]]

This bug was caught by the test widget/tests/test_standalone_native_menu.xhtml.

Comment 4

[Cam]

Please reconsider, this makes it impossible for me to use the native context menu.

Comment 5

[Cam]

Or at least allow up to deny extensions permission to populate the context menu, that'd be even better as it helps all platforms.