Closed Bug 1700740 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28225 - Test should assert if bodiesNum is 0

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28225 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28225
Details from upstream follow.

b'Trevor Rowbotham <trevor.rowbotham@pm.me>' wrote:

Test should assert if bodiesNum is 0

Currently, clearing-stack-back-to-a-table-body-context.html#L54 will only assert that bodiesNum === table.tBodies.length if bodiesNum is truthy, however, clearing-stack-back-to-a-table-body-context.html#L127 specifies 0 for bodiesNum, which is falsy and we skip the assert. Presumably, we want to assert if an integer is given so we change the condition to explicitly check for null and undefined instead.

This also proactively fixes the same condition in clearing-stack-back-to-a-table-context.html#L46

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
PASS: 39

Chrome

OK : 2
PASS: 39

Safari

OK : 2
PASS: 39

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/089f53b3dfdb [wpt PR 28225] - Test should assert if bodiesNum is 0, a=testonly
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.