1700871 - submitting a form targetting an iframe results in window changing from background to foreground

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Gerrit Schulz]

Attachment: ZIP archive containing html-Files for reproducing the problem.

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

We have a page ("main page") that contains a form and an iframe. The main page submits said form periodically targetting the iframe.

Actual results:

If the main page is in the background while a different window has the focus the main page changes from background to foreground as soon as the main page submits its form.

Expected results:

The main page should stay in the background. This was the behavior of Firfox before version 86 and still is the behavior in other browsers like Chrome and Edge.

Comment 1

[Gerrit Schulz]

Comment on attachment 9211430 [details]
ZIP archive containing html-Files for reproducing the problem.

To reproduce the problem unzip the archive "example_pages.zip" and open the page_background.html file. Then click the button to open a new page in the foreground. After 10 seconds the page in the background submits it's form targetting the iframe and its window changes from background to foreground.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Sounds like a regression of 87. We need to know which bug fix caused this.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Is this possibly related to all the changes around bug 1694927

Comment 5

[Edgar Chen [:edgar]]

27:28.26 INFO: Last good revision: 57c02aedb3c8f5c2126e5b739f11cbf0e30d134e
27:28.26 INFO: First bad revision: d3539dfe1b07c4937e084844999c515475e869bb
27:28.26 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=57c02aedb3c8f5c2126e5b739f11cbf0e30d134e&tochange=d3539dfe1b07c4937e084844999c515475e869bb

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

I put up an slightly more complex test-case here... I'm not sure all the chrome heuristics make sense...

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1700871 - Only allow focus move for links / form submission iff actually handling user input. r=smaug

The other navigation that allows focus moves (window.open) already goes
through the popup blocker, so that one is fine.

I think given how weird yet conservative other browsers are, this should
be a good trade-off to avoid false positives.

If you agree with this I'll add a test for the form submission bits.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c180c9324be
Only allow focus move for links / form submission iff actually handling user input. r=smaug

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1c180c9324be

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9212408 [details]
Bug 1700871 - Only allow focus move for links / form submission iff actually handling user input. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Makes us focus-steal less, behavior is be closer to that of other browsers.
• String changes made/needed: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9212408 [details]
Bug 1700871 - Only allow focus move for links / form submission iff actually handling user input. r=smaug

Approved for 88.0b6.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/40ae6b7075cc

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50ebb8f5788d
Tentatively fix macOS permafail in browser_bug1691214.js.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/99d7b99aa45e

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/50ebb8f5788d

Comment 17

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 89.0a1 (2012.03.25) on Win 8.1 x64 and Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 89.0a1 (latest nightly) and 88.0b6 on Win 10 x64, macOS 11.2 and Ubuntu 20.04 x64.