1700890 - A row of space is missing between the “Logins and passwords imported to Firefox” description and the “Learn more” link on the “Import Summary Report” page

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: MissingARowSpace_SummaryPage.PNG

[Affected versions]:

• Firefox Nightly 89.0a1 (Build ID: 20210322174641)
• Firefox Beta 88.0b2 (Build ID: 20210324160546)

[Affected Platforms]:

• Mac 11.2.3
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest version of Firefox Nightly installed.
• Have saved on your computer a CSV file that contains only valid logins.

[Steps to reproduce]:

1. Open the Firefox browser.
2. Navigate to the "about:logins" page.
3. Click on the Menu button.
4. Select the “Import from a File…” option.
5. Select the CSV file from prerequisites and click on the “Open” button from the “Import Logins File” picker.
6. Click on the “View detailed Import Summary” link.
7. Observe the top part area from the “Import Summary Report” page.

[Expected result]:

• The spacing between the “Logins and passwords imported to Firefox” description and the “Learn more” link is larger.

[Actual result]:

• The spacing between the “Logins and passwords imported to Firefox” description and the “Learn more” link is missing.

[Notes]:

• Based on the mock-ups a row of space should be displayed under the “Logins and passwords imported to Firefox” description.
• Attached a screenshot with the issue.

Comment 1

[Sarah Ukoha]

Has this been assigned to anyone? If not, please can this be assigned to me as a good beginner's bug to fix.
Also if I can be pointed to right files to modify...
Thanks

Comment 2

[Tim Giles [:tgiles]]

Hey Sarah, I can help get you started with this bug.

To help Mozilla out with this bug, here's the steps:

2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Developer Guide,
     which has answers to most development questions.
3. Start working on this bug.
   • You will need to add some padding between the elements seen in the screenshot in Comment #0. These styles can be found in browser/components/aboutlogins/aboutLoginsImportReport.css. Most likely you will need to modify the rule for .summary > div and add padding to it.
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #lockwise-desktop channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and test your change with
   mach test browser/components/aboutlogins --headless.
   Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 3

[Sarah Ukoha]

Attachment: Bug 1700890 - Add a row of space between the 'Logins and passwords imported to Firefox' description and the 'Learn more' link on the 'Import Summary Report' page r=tgiles

Comment 4

[Sarah Ukoha]

Attachment: Bug 1700890 - Add a row of space between the 'Logins and passwords imported to Firefox' description and the 'Learn more' link on the 'Import Summary Report' page r=tgiles

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba4e255a04fb
Add a row of space between the 'Logins and passwords imported to Firefox' description and the 'Learn more' link on the 'Import Summary Report' page r=tgiles

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ba4e255a04fb

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Nightly 89.0a1 (Build ID: 20210412213434) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The spacing between the “Logins and passwords imported to Firefox” description and the “Learn more” link from the “Import Summary Report” page is larger with a row of space.