1700893 - The subtitle and the description under each logins number from the “Import Summary Report” page are bold

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA, PTO - NI to: [e-mail]]

Attachment: BoldText_SummaryPage.PNG

[Affected versions]:

• Firefox Nightly 89.0a1 (Build ID: 20210322174641)
• Firefox Beta 88.0b2 (Build ID: 20210324160546)

[Affected Platforms]:

• Mac 11.2.3
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest version of Firefox Nightly installed.
• Have saved on your computer a CSV file that contains only valid logins.

[Steps to reproduce]:

1. Open the Firefox browser.
2. Navigate to the "about:logins" page.
3. Click on the Menu button.
4. Select the “Import from a File…” option.
5. Select the CSV file from prerequisites and click on the “Open” button from the “Import Logins File” picker.
6. Click on the “View detailed Import Summary” link.
7. Observe the text from the top part of the“Import Summary Report” page.

[Expected result]:

• Only the numbers of logins imported/not imported and the “Import Summary” title are bold.

[Actual result]:

• The whole text from the top part of the “Import Summary Report” page is bold.

[Notes]:

• Based on the mock-ups the “Logins and passwords imported to Firefox” subtitle and the description displayed under each number of logins are not bolded.
• Attached a screenshot with the issue.

Comment 1

[Sam Foster [:sfoster] (he/him)]

I don't think we need a regression window here as its a new feature.

Comment 2

[Jane Kotovich (:janey)]

Hey! Its Jane from Outreachy, could I please work on this bug? Thanks

Comment 3

[Sarah Ukoha]

Oh, I see Jane has requested for this already.
Kindly assign to either of us, will be glad to oblige!
Sarah, from Outreachy.

Comment 4

[Tim Giles [:tgiles]]

Hi Jane, since you commented first, I'm going to assign you this bug. Sarah, thanks for bringing this to my attention.

To help Mozilla out with this bug, here's the steps:

2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You will need to adjust the font weight of the various elements seen in the screenshot in Comment #0. These styles can be found in aboutLoginsImportReport.css
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #lockwise-desktop channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/components/aboutlogins/tests/ --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 5

[Sarah Ukoha]

Much obliged! Crack this up Jeny!! Congratulations!! :)

Comment 6

[Jane Kotovich (:janey)]

Attachment: Bug 1700893 - Fix font-weight and spacing on subtitle and count descriptions on the CSV Import Summary report. r=tgiles

Depends on D111743

Comment 7

[Jane Kotovich (:janey)]

Hey Tim, all clear as day, thank you so much! The only one thing - I have submitted a patch however as it says - "The r=reviewers part is optional; if you are using Phabricator, Lando will add it automatically based on who actually granted review, and in any case the person who does the final check-in of the patch will make sure it’s added" - so I didn't choose any specific review. And now wonder was it correct or not. Apart of that, everything went great, tests went through, and change took me few moments. Looking forward for more riddles!
Btw, nice to meet you :)
(In reply to Tim Giles [:tgiles] from comment #4)

Hi Jane, since you commented first, I'm going to assign you this bug. Sarah, thanks for bringing this to my attention.

To help Mozilla out with this bug, here's the steps:

2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You will need to adjust the font weight of the various elements seen in the screenshot in Comment #0. These styles can be found in aboutLoginsImportReport.css
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #lockwise-desktop channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/components/aboutlogins/tests/ --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 8

[Jane Kotovich (:janey)]

Oh as well I have added a little margin-top for Subtitles cause they were getting too close to numbers. hope its okay! 👌

Comment 9

[Jane Kotovich (:janey)]

Hi Tim.
Sorry wasn't sure should I tag you to make a review or it happens automatically.
Big thanks in both ways and sorry for disturbing!
(In reply to Tim Giles [:tgiles] from comment #4)

Hi Jane, since you commented first, I'm going to assign you this bug. Sarah, thanks for bringing this to my attention.

To help Mozilla out with this bug, here's the steps:

2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You will need to adjust the font weight of the various elements seen in the screenshot in Comment #0. These styles can be found in aboutLoginsImportReport.css
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #lockwise-desktop channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/components/aboutlogins/tests/ --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 10

[Tim Giles [:tgiles]]

(In reply to Evgenia Kotovich from comment #9)

Hi Tim.
Sorry wasn't sure should I tag you to make a review or it happens automatically.
Big thanks in both ways and sorry for disturbing!

Hey Jane, no worries. Pleasure to meet you as well. In order for a review to pop up in my queue, I will need to be added to the patch you've submitted. You can add me as a reviewer by selecting the "Edit Revision", scroll down to "Reviewers", and start typing "tgiles". My name should appear in the autocomplete. Afterwards the patch will appear in my queue in Phabricator once it is marked as "Needs Review".

Currently the patch is in the "Changes Planned" state (or --wip state). You will need to mark this patch for review by selecting the "Add Action" button near the bottom of the patch and selecting "Mark for review" (or whatever the language is, I don't remember the exact string off the top of my head hah).

Let me know if you need additional help by either messaging me in Matrix or needinfo'ing me on this ticket!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1a9202a6220
Fix font-weight and spacing on subtitle and count descriptions on the CSV Import Summary report. r=tgiles

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a1a9202a6220

Comment 13

[Simona Rosu [:srosu], Ecosystem QA, PTO - NI to: [e-mail]]

I have verified this issue using the latest Nightly 89.0a1 (Build ID: 20210418213620) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The subtitle and the description under each login number from the “Import Summary Report” page are no longer bold.