1700903 - Don't reject slightly unsual webm files

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Paul Adenot (:padenot)]

Attachment: lost-delirious-beautiful-1.webm

STR:

• Open https://ignace72.eu/lost-delirious-beautiful.html (also attached for posterity)

Expected:

• The video plays

Actual:

• The video doesn't play

The Webm container has a codec_delay of 0, but then when actually decoding the Opus stream, we find that there is a non-zero delay, and we bail. Simply relaxing this check makes it work. This files is played by all other software I've tried.

I can't find a normative text that says that those number should be equal, so we probably should accept this file.

Maybe a bad muxer? This file appears to have been produced with ffmpeg, maybe with youtube-dl or something.

Comment 1

[Paul Adenot (:padenot)]

(In reply to Paul Adenot (:padenot) from comment #0)

The Webm container has a codec_delay of 0

After looking at the file in more detail, it simply doesn't have a delay field.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1700903 - Don't reject file when webm codec delay and opus pre-skip do not match. r?kinetik

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1700903 - Add a test. r?kinetik

This is the file attached to the bug, trimmed right after the first cluster:

truncate --size=66250 ~/lost-delirious-beautiful-1-trimmed.webm

Depends on D109705

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af90373d8ef6
Don't reject file when webm codec delay and opus pre-skip do not match. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/81294dc587fe
Add a test. r=kinetik

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/af90373d8ef6
https://hg.mozilla.org/mozilla-central/rev/81294dc587fe