Closed
Bug 1700951
Opened 4 years ago
Closed 3 years ago
Make DoHController watch for captive-portal-login instead of connectivity
Categories
(Firefox :: Security, defect, P1)
Firefox
Security
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
Attachments
(1 file, 1 obsolete file)
Presently the DoHController used "network:captive-portal-connectivity" to react to captive portal events and trigger heuristics.
The problem is this notification is triggered unconditionally each time a captive portal check is completed, which is every minute and sometimes more often.
This is very inefficient. We should be watching the "captive-portal-login-success" topic instead, which is sent only when the detector was in a captive portal but managed to log in.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9211493 -
Attachment is obsolete: true
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1815c889954f
Make DoHController watch for network:captive-portal-connectivity-changed instead r=nhnt11
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•