Closed Bug 1700971 Opened 4 years ago Closed 4 years ago

Switch to search engine extensions and use random port numbers in urlbar xpcshell-tests

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
3

Tracking

()

RESOLVED FIXED
89 Branch
Iteration:
89.1 - Mar 22 - Apr 4
Tracking Status
firefox89 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Currently when we run the urlbar xpcshell-tests, a bunch of them fail when run in parallel, and the pass when run in sequence.

This is because we're currently using OpenSearch definitions for the search engines they use, which force us into using a fixed port as they are pre defined in a file.

Now we have SearchTestUtils.installSearchExtension, this allows us to construct the search urls dynamically, so we should use that instead.

This allows us to use random port numbers in the tests, so that they can run in parallel.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bef51c405b1f Switch to using search engine extensions in urlbar xpcshell-tests. r=mak
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

This is great, thank you Mark!

Iteration: --- → 89.1 - Mar 22 - Apr 4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: