1700990 - Fix frame descriptor for the entry frame

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

We construct this frame descriptor incorrectly in generateEnterJIT: the descriptor's frame size shouldn't include the numActualArgs and calleeToken of the JitFrameLayout as they are already included in the 'header size'.

This doesn't affect anything today, but it will simplify the profiler changes in bug 1700869.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1700990 - Fix frame descriptor for the entry frame. r?nbp!

The descriptor's frame size shouldn't include the numActualArgs and calleeToken of
the JitFrameLayout because these fields are already included in the 'header size'.

Change the trampolines to create the frame descriptor before pushing the JitFrameLayout.
This is consistent with how we do this for non-entry frames.

This doesn't affect anything yet, but it will simplify the profiler changes in
bug 1700869.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adad444082d2
Fix frame descriptor for the entry frame. r=nbp

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/adad444082d2