1700996 - Dark theme "Find in page" infobar navigation buttons are too dark on MacOS

Status: NEW

(Firefox :: Theme, defect, P2)

Description

[Peter Magyari (Desktop QA)]

Attachment: Screenshot 2021-03-25 at 18.49.34.png

Preconditions
browser.proton.enabled = true
browser.proton.infobars.enabled = true

Steps

1. Start Firefox Nightly
2. Go to about:addons and enable Dark theme or Proton Dark theme
3. Open a new tab and open the "Find in page" infobar (cmd+f)

Expected Result
The "Navigate through next and previous occurrence of phrase" buttons are easily distinguishable

Actual Result
The "Navigate through next and previous occurrence of phrase" buttons are too dark compared to the ones on Windows and Linux

Comment 1

[Romain Testard [:RT]]

I believe this is now fixes, can you please retest and validate?

Comment 2

[Peter Magyari (Desktop QA)]

Hi Romain,

It doesn't seem to be fixed on the latest Firefox Nightly (20210404214218)

Comment 3

[Ed Lee :Mardak]

Looks like without a search makes the up/down toolbarbutton[disabled="true"] uses -moz-mac-disabledtoolbartext whereas other platforms use GrayText

https://searchfox.org/mozilla-central/search?q=toolbarbutton%5Bdisabled%3D%22true%22%5D

And additionally, they're 0.4 opacity:
https://searchfox.org/mozilla-central/rev/436f1fae6f4f6855911bd603b3150ab5b72b8a84/toolkit/themes/shared/findBar.inc.css#126-128