1701024 - Reopen All X footer item in Recently Closed Tabs / Recently Closed Windows has incorrect left alignment

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

See screenshot. The text in the item should be left aligned to the tab/window icons.

Comment 1

[Itiel]

Adding these:

.panel-subview-footer-button > .toolbarbutton-icon {
  display: none;
}

.panel-subview-footer-button > .toolbarbutton-text {
  padding-inline-start: 0;
}

and moving this line:
https://searchfox.org/mozilla-central/rev/bb37e6fe8bbe383a57a4ad21a201e26416613ca1/browser/themes/shared/customizableui/panelUI.inc.css#1305
to a @supports not proton block seem to fix it for me on Windows.

Not sure if that's the right fix though, I don't know if there are (or will be) footer-buttons that should have an icon...
If it's the latter then referencing .subviewbutton.restoreallitem in the 2 rules above instead of .panel-subview-footer-button should do it.

Comment 2

[Michael Kohler [:mkohler]]

Attachment: Fixed

This by now looks good to me for both tabs and windows on latest Windows Nighly at least.

Comment 3

[:Gijs (he/him)]

Same for me as comment #2, so (belatedly) closing this out.