Closed Bug 1701041 Opened 2 years ago Closed 2 years ago

Various spacing issues in Permission Panels with Proton enabled

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mconley, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers] [priority:2b] [proton-uplift])

Attachments

(1 file)

Bug 1701041: fix spacing and alignment for permission panels
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
  1. The gap between the top of the panel and the panel description should be 16px. Currently, it appears to be closer to 20px.
  2. The gap between the bottom buttons and the bottom of the panel should also be 16px. Currently, it appears to be closer to 19px.
  3. The menulists in the WebRTC panels have too much of a gap between the end of the menulist and the right side of the panel. The gap should be 16px in total.
  4. The large-style menulists are too tall. The ones in the WebRTC panel are 36px in height, when they should be 32px.
  5. The gap between an un-iconed menulist label and its starting edge should be 16px. Currently, it appears to be 20px.
  6. Similarly, there should be 16px spacing around the dropdown icon on its right side, and 8px of spacing above and below the icon.
Priority: -- → P2
Keywords: helpwanted
Whiteboard: [proton-door-hangers] → [proton-door-hangers][priority:2b]

This can be also seen in the geolocation permission, where the "Learn more" link is too close positioned to the "Remember this decision" checkbox.

Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Whiteboard: [proton-door-hangers][priority:2b] → [proton-door-hangers] [priority:2b]
Assignee: prathikshaprasadsuman → nobody
Status: ASSIGNED → NEW
Assignee: nobody → emalysz
Status: NEW → ASSIGNED

-Adjusts spacing between top of panel and panel description
-Adjusts spacing between bottom buttons and bottom of panel
-Removes inline margin from menulists
-Fixed height for menulists

Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91d2ab692f2a
fix spacing and alignment for permission panels r=mconley

https://hg.mozilla.org/mozilla-central/rev/91d2ab692f2a

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9219041 [details]
Bug 1701041: fix spacing and alignment for permission panels

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very simple, well-contained CSS-only patch for the permissions panels.
  • String changes made/needed: None.
Attachment #9219041 - Flags: approval-mozilla-beta?
status-firefox89: --- → affected
Whiteboard: [proton-door-hangers] [priority:2b] → [proton-door-hangers] [priority:2b] [proton-uplift]

Comment on attachment 9219041 [details]
Bug 1701041: fix spacing and alignment for permission panels

Approved for 89 beta 7, thanks.

Attachment #9219041 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.