Closed
Bug 1701055
Opened 2 years ago
Closed 2 years ago
Block margins around Learn more links in Permission Panels is wrong with Proton enabled
Categories
(Firefox :: Theme, defect, P2)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
90 Branch
People
(Reporter: mconley, Assigned: luzdelarosaramirez)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [proton-door-hangers][priority:2b] [proton-uplift])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
There should be a 4px margin above the Learn more link, and 16px below.
Updated•2 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-765
Updated•2 years ago
|
Priority: -- → P2
Reporter | ||
Updated•2 years ago
|
Keywords: helpwanted
Updated•2 years ago
|
Whiteboard: [proton-door-hangers] → [proton-door-hangers][priority:2b]
Updated•2 years ago
|
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Updated•2 years ago
|
Assignee: prathikshaprasadsuman → luzdelarosaramirez
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Attachment #9217417 -
Attachment description: Bug 1701055 - Block margins around Learn more links in Permission Panels is wrong with Proton enabled. r=prathiksha → Bug 1701055 - Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/078f1bd546bc Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Comment 4•2 years ago
|
||
Johann, does this need proton uplift? (see https://docs.google.com/document/d/1HhxPXur_FyvidEn9UP85rHpQeLWp56JbaIulfdoc6AI/edit for procedure)
Flags: needinfo?(jhofmann)
Comment 5•2 years ago
|
||
Comment on attachment 9217417 [details]
Bug 1701055 - Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very small CSS only patch.
- String changes made/needed: None
Attachment #9217417 -
Flags: approval-mozilla-beta?
Updated•2 years ago
|
Flags: needinfo?(jhofmann)
Updated•2 years ago
|
status-firefox89:
--- → affected
Whiteboard: [proton-door-hangers][priority:2b] → [proton-door-hangers][priority:2b] [proton-uplift]
Comment 6•2 years ago
|
||
Comment on attachment 9217417 [details]
Bug 1701055 - Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha
Approved for 89 beta 6, thanks.
Attachment #9217417 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•2 years ago
|
||
bugherderuplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•