Closed Bug 1701055 Opened 3 years ago Closed 3 years ago

Block margins around Learn more links in Permission Panels is wrong with Proton enabled

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mconley, Assigned: luzdelarosaramirez)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers][priority:2b] [proton-uplift])

Attachments

(1 file)

Bug 1701055 - Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

There should be a 4px margin above the Learn more link, and 16px below.

Priority: -- → P2
Keywords: helpwanted
Whiteboard: [proton-door-hangers] → [proton-door-hangers][priority:2b]
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Assignee: prathikshaprasadsuman → luzdelarosaramirez
Attachment #9217417 - Attachment description: Bug 1701055 - Block margins around Learn more links in Permission Panels is wrong with Proton enabled. r=prathiksha → Bug 1701055 - Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/078f1bd546bc
Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha

https://hg.mozilla.org/mozilla-central/rev/078f1bd546bc

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Johann, does this need proton uplift? (see https://docs.google.com/document/d/1HhxPXur_FyvidEn9UP85rHpQeLWp56JbaIulfdoc6AI/edit for procedure)

Flags: needinfo?(jhofmann)

Comment on attachment 9217417 [details]
Bug 1701055 - Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very small CSS only patch.
  • String changes made/needed: None
Attachment #9217417 - Flags: approval-mozilla-beta?
Flags: needinfo?(jhofmann)
status-firefox89: --- → affected
Whiteboard: [proton-door-hangers][priority:2b] → [proton-door-hangers][priority:2b] [proton-uplift]

Comment on attachment 9217417 [details]
Bug 1701055 - Update block margins around Learn more links in permission panels with Proton enabled. r=prathiksha

Approved for 89 beta 6, thanks.

Attachment #9217417 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.