1701059 - Addon install confirmation panel "Okay" button is too wide with Proton enabled

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

This button should look more like the attachment.

Comment 1

[Luz De La Rosa]

Attachment: Bug 1701059 - Addon install confirmation panel Okay button is too wide with Proton enabled. r=prathiksha

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/815e96ee0292
Addon install confirmation panel Okay button is too wide with Proton enabled. r=desktop-theme-reviewers,dao

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/815e96ee0292

Comment 4

[Ciprian Georgiu, Desktop QA]

We have verified that the "Okay" button is correctly displayed in the panel, with latest Nightly 90.0a1 under macOS 10.15, Ubuntu 18.04 x64 and Win 10 x64.

Comment 5

[Caitlin Neiman [:caitmuenster]]

Thank you so much for the patch, @luzdelarosa! 🎉 Your contribution has been added to our recognition wiki at https://wiki.mozilla.org/Add-ons/Contribute/Recognition.

Welcome onboard! Hope to see you around. :)

Comment 6

[Luz De La Rosa]

(In reply to Caitlin Neiman [:caitmuenster] from comment #5)

Thank you so much for the patch, @luzdelarosa! 🎉 Your contribution has been added to our recognition wiki at https://wiki.mozilla.org/Add-ons/Contribute/Recognition.

Welcome onboard! Hope to see you around. :)

Thank you so much! 🎉 🎉

Comment 7

[:Gijs (he/him)]

Mike or Dão, can you request uplift here if necessary? ( https://docs.google.com/document/d/1HhxPXur_FyvidEn9UP85rHpQeLWp56JbaIulfdoc6AI/edit for reference )

Comment 8

[Mike Conley (:mconley) (:⚙️)]

On it.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9216857 [details]
Bug 1701059 - Addon install confirmation panel Okay button is too wide with Proton enabled. r=prathiksha

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small CSS only patch.
• String changes made/needed: None.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9216857 [details]
Bug 1701059 - Addon install confirmation panel Okay button is too wide with Proton enabled. r=prathiksha

Approved for 89 beta 6, thanks.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/13812bdeedb5