Closed Bug 1701059 Opened 4 years ago Closed 4 years ago

Addon install confirmation panel "Okay" button is too wide with Proton enabled

Categories

(WebExtensions :: Frontend, defect, P2)

Product:
WebExtensions
Component:
Frontend
Type:
defect

Tracking

(firefox89 fixed, firefox90 verified)

Status:
VERIFIED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- verified

People

(Reporter: mconley, Assigned: luzdelarosaramirez)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers][priority:2c] [proton-uplift])

Attachments

(2 files)

image.png
31.37 KB, image/png
Details
Bug 1701059 - Addon install confirmation panel Okay button is too wide with Proton enabled. r=prathiksha
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
Attached image image.png —

This button should look more like the attachment.

Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Priority: -- → P2
Severity: -- → S3
Whiteboard: [proton-door-hangers] → [proton-door-hangers][priority:2c]
Assignee: prathikshaprasadsuman → luzdelarosaramirez
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/815e96ee0292 Addon install confirmation panel Okay button is too wide with Proton enabled. r=desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/815e96ee0292

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

We have verified that the "Okay" button is correctly displayed in the panel, with latest Nightly 90.0a1 under macOS 10.15, Ubuntu 18.04 x64 and Win 10 x64.

Status: RESOLVED → VERIFIED
status-firefox90: fixed → verified

Thank you so much for the patch, @luzdelarosa! 🎉 Your contribution has been added to our recognition wiki at https://wiki.mozilla.org/Add-ons/Contribute/Recognition.

Welcome onboard! Hope to see you around. :)

(In reply to Caitlin Neiman [:caitmuenster] from comment #5)

Thank you so much for the patch, @luzdelarosa! 🎉 Your contribution has been added to our recognition wiki at https://wiki.mozilla.org/Add-ons/Contribute/Recognition.

Welcome onboard! Hope to see you around. :)

Thank you so much! 🎉 🎉

Mike or Dão, can you request uplift here if necessary? ( https://docs.google.com/document/d/1HhxPXur_FyvidEn9UP85rHpQeLWp56JbaIulfdoc6AI/edit for reference )

Flags: needinfo?(mconley)
Flags: needinfo?(dao+bmo)

On it.

Flags: needinfo?(mconley)
Flags: needinfo?(dao+bmo)

Comment on attachment 9216857 [details]
Bug 1701059 - Addon install confirmation panel Okay button is too wide with Proton enabled. r=prathiksha

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very small CSS only patch.
  • String changes made/needed: None.
Attachment #9216857 - Flags: approval-mozilla-beta?
status-firefox89: --- → affected
Whiteboard: [proton-door-hangers][priority:2c] → [proton-door-hangers][priority:2c] [proton-uplift]

Comment on attachment 9216857 [details]
Bug 1701059 - Addon install confirmation panel Okay button is too wide with Proton enabled. r=prathiksha

Approved for 89 beta 6, thanks.

Attachment #9216857 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: