1701108 - "Wrong button set to eContextMenu event?" after right-clicking in tab content

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Markus Stange [:mstange]]

In a debug build, if I right click the content area and wait for a bit, I see the following warning:

[Parent 59505, Main Thread] WARNING: Wrong button set to eContextMenu event?: 'mMessage != eContextMenu || (mButton == ((mContextMenuTrigger == eNormal) ? MouseButton::eSecondary : MouseButton::ePrimary) && (mContextMenuTrigger != eControlClick || IsControl()))', file /Users/mstange/code/obj-m-debug/dist/include/mozilla/MouseEvents.h:244

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1701108 - Split this assertion up into three assertions that are easier to understand. r=masayuki

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1701108 - Create synthesized contextmenu event with button 2 ("eSecondary") to keep assertions happy. r=Gijs

We have a warning assertion that wants all contextmenu events to have button 2,
or be marked as a ctrl-click or triggered by the contextmenu keyboard key.
Fixing this avoids a warning in debug builds but is otherwise inconsequential.

Depends on D109825

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4947072b25b9
Split this assertion up into three assertions that are easier to understand. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/99c3e75fd029
Create synthesized contextmenu event with button 2 ("eSecondary") to keep assertions happy. r=Gijs

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4947072b25b9
https://hg.mozilla.org/mozilla-central/rev/99c3e75fd029