170112 - Shift-spacebar should scroll up in the browser window

Status: RESOLVED FIXED

(Camino Graveyard :: Accessibility, defect)

Description

[Simon Fraser [no longer active]]

Hitting the spacebar scrolls the browser window down, so shift-spacebar should
scroll it up.

Comment 1

[Lewis Francis]

What do the HI guidelines say about this?  I see that Mail.app backs up the page
with both shift-space AND option-space, as does Omniweb.  IE accepts just
option-space.  

Comment 2

[sairuh (rarely reading bugmail)]

how about implementing both option-space and shift-space? but if we had to
choose only one, option-space would prolly be better, since that's what OmniWeb
and IE use.

Comment 3

[sairuh (rarely reading bugmail)]

*** Bug 170591 has been marked as a duplicate of this bug. ***

Comment 4

[Sören 'Chucker' Kuklau (gone)]

Shift-space makes more sense to me, if you consider "shift" the "opposite", and
"option" a "variation".

Comment 5

[Norbert Rittel]

I vote for having Shift-Space - simply because:
On Apple's current portable computers you only have a Shift key on the right
hand side of the keyboard, no Option key there. So for lefties it does matter,
but for most of us having Shift-Space to scroll up is much more handy on a
PowerBook or iBook.

Comment 6

[sairuh (rarely reading bugmail)]

*** Bug 174411 has been marked as a duplicate of this bug. ***

Comment 7

[Simon Fraser [no longer active]]

See bug 79047 and bug 104371. Taking.

Comment 8

[Stephane Moureau]

Is there not a conflict with Extended keyboard navigation, space is used to be a
click, see AAHIG ?

Comment 9

[sairuh (rarely reading bugmail)]

within the content area, i think space acts like a click for certain html form
elements when they are in focus (namely the checkbox, radiobutton and buttons).
space won't act as a click for focused html elements like links, droplists,
scrolling lists, textareas, textfields, or even at the document-level. (esp the
last, where space needs to scroll down. :)

Comment 10

[Nalgas D. Lemur]

I vote for shift-space, partly because it's what I'm used to, partly because I'm on an iBook with two shift keys and only one option key, and partly because it seems pretty traditional to use shift to reverse direction (shift-tab to move backwards through fields instead of forwards, cmd-shift-tab to move backwards through open applications instead of forwards, etc.), and it would be nice to keep that consistant.

Comment 11

[Derek Schrock]

Conflict with HIG or not Safari does it.

Voting for this bug.

Shift-space.

Comment 12

[Cedric Luthi]

iCab does it as well with space-shift. I'm voting for this bug too. Anyway this
key combination is used in many applications other than browsers.

Comment 13

[Ludovic Hirlimann [:Usul]]

still true with 2003090102 on 10.2.6.

Comment 14

[Simon Fraser [no longer active]]

Taking, have fix.

Comment 15

[Simon Fraser [no longer active]]

Attachment: Fix; fill in event modifiers

This patch fills in the nsKeyEvent modifiers for the event that is used for
space-down and shift-space-up.

Comment 16

[Simon Fraser [no longer active]]

Seeking reviews

Comment 17

[Kathleen :Brade]

Comment on attachment 141972 [details] [diff] [review]
Fix; fill in event modifiers

r=brade

Comment 18

[Simon Fraser [no longer active]]

Fixed.

Comment 19

[Samir Gehani]

Thanks Simon!  With this fix you have added one more new full-time user of Camino.