I'm going to attach a patch with some miscellaneous performance improvements that are mostly from various hacks I did while looking at the part of a page-loading profile related to kicking off image loads (in particular, to constructing the URI for the image loads). These aren't huge wins -- probably they total about 0.3% of page load time. I still have to re-profile to get better numbers.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.2beta
darin's recent changes to nsHttpHandler made the nsHttpHandler changes here obsolete.
Attachment #100117 - Attachment is obsolete: true
Comment on attachment 101917 [details] [diff] [review] updated patch r/sr=darin
Attachment #101917 - Flags: superreview+
Is this going to make 1.2b ... hope so :)
Comment on attachment 101917 [details] [diff] [review] updated patch > NS_PRECONDITION(nsnull != aManager, "null ptr"); Not your code, but drop the "nsnull !=" part, eh? I assume that you'll land the change to nsImageFrame.h as well and that that just changes the GetRealURI signature? If so, r/sr=bzbarsky
Attachment #101917 - Flags: review+
Created attachment 102726 [details] [diff] [review] patch with bz's suggestions This removes the "nsnull !=" and includes the missing header file.
Attachment #101917 - Attachment is obsolete: true
Comment on attachment 102726 [details] [diff] [review] patch with bz's suggestions Transferring r and sr.
Perf work this trivial doesn't go into 1.2 at this stage.
Target Milestone: mozilla1.2beta → mozilla1.3alpha
Fix checked in to trunk, 2002-11-06 04:57/58 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.