miscellaneous performance improvements mostly related to image loads

RESOLVED FIXED in mozilla1.3alpha

Status

SeaMonkey
General
P3
normal
RESOLVED FIXED
16 years ago
13 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({perf})

Trunk
mozilla1.3alpha

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

16 years ago
I'm going to attach a patch with some miscellaneous performance improvements
that are mostly from various hacks I did while looking at the part of a
page-loading profile related to kicking off image loads (in particular, to
constructing the URI for the image loads).

These aren't huge wins -- probably they total about 0.3% of page load time.  I
still have to re-profile to get better numbers.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P3
Whiteboard: [patch]
Target Milestone: --- → mozilla1.2beta
(Assignee)

Comment 2

16 years ago
darin's recent changes to nsHttpHandler made the nsHttpHandler changes here
obsolete.
(Assignee)

Comment 3

16 years ago
Created attachment 101917 [details] [diff] [review]
updated patch
(Assignee)

Updated

16 years ago
Attachment #100117 - Attachment is obsolete: true

Comment 4

16 years ago
Comment on attachment 101917 [details] [diff] [review]
updated patch

r/sr=darin
Attachment #101917 - Flags: superreview+

Comment 5

16 years ago
Is this going to make 1.2b ... hope so :)
Comment on attachment 101917 [details] [diff] [review]
updated patch

>   NS_PRECONDITION(nsnull != aManager, "null ptr");

Not your code, but drop the "nsnull !=" part, eh?

I assume that you'll land the change to nsImageFrame.h as well and that that
just changes the GetRealURI signature?	If so, r/sr=bzbarsky
Attachment #101917 - Flags: review+
(Assignee)

Comment 7

16 years ago
Created attachment 102726 [details] [diff] [review]
patch with bz's suggestions

This removes the "nsnull !=" and includes the missing header file.
Attachment #101917 - Attachment is obsolete: true
(Assignee)

Comment 8

16 years ago
Comment on attachment 102726 [details] [diff] [review]
patch with bz's suggestions

Transferring r and sr.
Attachment #102726 - Flags: superreview+
Attachment #102726 - Flags: review+

Updated

16 years ago
Keywords: mozilla1.2
(Assignee)

Comment 9

16 years ago
Perf work this trivial doesn't go into 1.2 at this stage.
Keywords: mozilla1.2
Target Milestone: mozilla1.2beta → mozilla1.3alpha
(Assignee)

Comment 10

16 years ago
Fix checked in to trunk, 2002-11-06 04:57/58 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.