170116 - miscellaneous performance improvements mostly related to image loads

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm going to attach a patch with some miscellaneous performance improvements
that are mostly from various hacks I did while looking at the part of a
page-loading profile related to kicking off image loads (in particular, to
constructing the URI for the image loads).

These aren't huge wins -- probably they total about 0.3% of page load time.  I
still have to re-profile to get better numbers.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

darin's recent changes to nsHttpHandler made the nsHttpHandler changes here
obsolete.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: updated patch

Comment 4

[Darin Fisher]

Comment on attachment 101917 [details] [diff] [review]
updated patch

r/sr=darin

Comment 5

[Markus Hübner]

Is this going to make 1.2b ... hope so :)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 101917 [details] [diff] [review]
updated patch

>   NS_PRECONDITION(nsnull != aManager, "null ptr");

Not your code, but drop the "nsnull !=" part, eh?

I assume that you'll land the change to nsImageFrame.h as well and that that
just changes the GetRealURI signature?	If so, r/sr=bzbarsky

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch with bz's suggestions

This removes the "nsnull !=" and includes the missing header file.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 102726 [details] [diff] [review]
patch with bz's suggestions

Transferring r and sr.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Perf work this trivial doesn't go into 1.2 at this stage.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2002-11-06 04:57/58 PDT.