Closed Bug 1701202 Opened 8 months ago Closed 8 months ago

Fix some browser mochitests so we can enable proton on nightly

Categories

(Firefox :: General, task)

Desktop
All
task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Whiteboard: [proton-foundations])

Attachments

(1 file)

In order to flip the main proton pref on nightly we need to fix a bunch of tests. I'm going to try to pick off a few in this bug.

Whiteboard: [proton-foundations]
Priority: P1 → --
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d885acd20f7e
fix some browser mochitests to pass with proton enabled, r=mconley

Backed out for failures on browser_synced_tabs_menu.js

backout https://hg.mozilla.org/integration/autoland/rev/0b43c44aa242980a1ddffe37953383462f93cb71

push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=OBuHwwJSQxuhpti2TSBTfQ.0&revision=d885acd20f7e4573d682533e401ea7cad68a307c&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=334591086&repo=autoland&lineNumber=2979

[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - TEST-PASS | browser/components/customizableui/test/browser_synced_tabs_menu.js | The panel UI is in default state again. -
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - Buffered messages finished
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_synced_tabs_menu.js | Uncaught exception - at resource:///modules/UITour.jsm:352 - TypeError: can't access property "set", this.actions is undefined
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - Stack trace:
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - init@resource:///modules/UITour.jsm:352:9
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - @resource:///modules/UITour.jsm:2171:8
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - asyncCleanup@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_synced_tabs_menu.js:165:3
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - Leaving test bound asyncCleanup
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - Entering test bound
[task 2021-03-26T19:34:33.387Z] 19:34:33 INFO - GECKO(1561) | console.info: Skipping device list refresh; not signed in
[task 2021-03-26T19:34:33.388Z] 19:34:33 INFO - Check Sync button functionality
[task 2021-03-26T19:34:33.388Z] 19:34:33 INFO - Waiting for overflow button to show
[task 2021-03-26T19:34:33.389Z] 19:34:33 INFO - Checking if element has non-0 size
[task 2021-03-26T19:34:33.513Z] 19:34:33 INFO - TEST-PASS | browser/components/customizableui/test/browser_synced_tabs_menu.js | The Sync button was added to the Panel Menu -

Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9b3086eafa6a
fix some browser mochitests to pass with proton enabled, r=mconley
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.