Closed
Bug 1701259
Opened 3 years ago
Closed 3 years ago
Deleting folders only warns about filters for the last account
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(thunderbird_esr78 wontfix)
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | wontfix |
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
2.79 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
When you delete a folder, Thunderbird is supposed to warn you if this will affect one or more of your filters. However due to a logic error this warning only happens for the last account's filters.
|
Assignee | |
Comment 1•3 years ago
|
||
The bug is that each call to match the filter list overwrites the return value, so only the editable filter list from the last server is properly accounted for. Instead, all the values need to be combined, so that if any server (typically the folder's server) has a filter for that folder then the user can be warned.
Assignee: nobody → neil
Attachment #9211808 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9211808 [details] [diff] [review] Proposed patch Review of attachment 9211808 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thx! r=mkmelin
Attachment #9211808 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•3 years ago
|
Status: NEW → ASSIGNED
status-thunderbird_esr78:
--- → affected
Keywords: checkin-needed-tb
Target Milestone: --- → 89 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0535136da6fd
Warn when deleting filter targets from any accounts r=mkmelin
|
|
||
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•