17013 - [ptr] native nsIFoo [without trailing paren] crashes xpidl

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Mike McCabe]

Travis Bogard wrote:

So to help you out with the crash.  I found the problem in the IDL that was
causing the crash.  Changing the line that had the native ptr declaration...

[ptr] native nsIPresContext; should be
[ptr] native nsIPresContext(nsIPresContext);

Travis

Comment 1

[Mike McCabe]

Attachment: the offending example

Comment 2

[Mike McCabe]

So it turns out that libIDL parses [ptr] native nsIFoo; quite happily, but xpidl
gets null when it tries to access .user_type and crashes in fputs.

Shaver, maybe you can help me out with the history some... 'native' is special
to xpidl, correct?  Is there any sense to libIDL accepting native nsIFoo;
without an associated (nsIUserType) ?  If no, we should flag this as invalid
syntax in libIDL.  I'll patch in something for now to catch it in xpidl.

Also, do you know if andrewtv has a buzilla login?

Comment 3

[Mike McCabe]

Adding andrewtv, I hope.

Comment 4

[Mike McCabe]

Yay!  Got your bugzilla ID right.

Andrew, can you comment?

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

|native| is from OMG IDL, where it's unparameterized.  We should flag it as an
error, my bad that we don't already.

Comment 6

[Mike McCabe]

Ah.  Yep, found it.  Bottom of page 3-14 in the Corba v2.3 IDL grammar.  Looks
like adding a trailing (foo) is an xpidl innovation.

I wonder if
 [ptr,id(nsIFoo)] native nsIFoo;
would have been a cleaner extension.

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Fix sent to mccabe for review.

(No, mccabe, that would have been ugly. =) )

Comment 8

[Mike McCabe]

Fixed.  Thanks, shaver.

Comment 9

[leger]

Adding crash keyword