User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2a) Gecko/20020910 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2a) Gecko/20020910 When user clicks on a file of previously-unknown type in the browser, a "What should Mozilla do with this file?" dialog pops up. If the user selects "Open using an application" and then clicks on "Choose", an untitled file picker window pops up. This window needs a title; it should probably be "Choose Application Helper" to match the file picker dialog from the Helper Applications settings in the Preferences menu. Also, in both this file picker and the Helper Applications file picker, the button used to confirm the file selection is "Open". This is misleading, however, since nothing is being opened. The button should probably read "Select" or "OK". Reproducible: Always Steps to Reproduce:
confirming on a current build... I'll try to get to this sometime in the near future as I poke at this code.
Assignee: law → bzbarsky
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Target Milestone: --- → mozilla1.6beta
Comment on attachment 126752 [details] [diff] [review] patch oh, a note: this patch only addresses the window title, not the button caption which is harder to change
Attachment #126752 - Flags: superreview?(bzbarsky)
Comment on attachment 126752 [details] [diff] [review] patch sr=me, but you may want to change the DTD to match whatever we have over in preferences (per original report). Note that what we have there may have changed since...
Attachment #126752 - Flags: superreview?(bzbarsky) → superreview+
Created attachment 126757 [details] [diff] [review] change dtd changes the dtd as requested. This uses the current dialog title as used in prefs (I checked).
Comment on attachment 126757 [details] [diff] [review] change dtd r/sr=bzbarsky
Attachment #126757 - Flags: superreview+
Created attachment 126762 [details] [diff] [review] change dtd v2 change both dialog titles to "choose helper application"
Attachment #126757 - Attachment is obsolete: true
16 years ago
Attachment #126762 - Flags: superreview?(bzbarsky)
Attachment #126762 - Flags: superreview?(bzbarsky) → superreview+
ok, the above patches were checked in: Checking in embedding/components/ui/helperAppDlg/locale/en-US/nsHelperAppDlg.dtd; /cvsroot/mozilla/embedding/components/ui/helperAppDlg/locale/en-US/nsHelperAppDlg.dtd,v <-- nsHelperAppDlg.dtd new revision: 1.9; previous revision: 1.8 done Checking in xpfe/components/prefwindow/resources/locale/en-US/pref-applications.properties; /cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-applications.properties,v <-- pref-applications.properties new revision: 1.5; previous revision: 1.4 done Checking in embedding/components/ui/helperAppDlg/nsHelperAppDlg.xul; /cvsroot/mozilla/embedding/components/ui/helperAppDlg/nsHelperAppDlg.xul,v <-- nsHelperAppDlg.xul new revision: 1.20; previous revision: 1.19 done Leaving the bug open for the caption of the "Open" button
Comment on attachment 126752 [details] [diff] [review] patch marking obsolete because it's checked in
Attachment #126752 - Attachment is obsolete: true
Comment on attachment 126762 [details] [diff] [review] change dtd v2 (same)
Attachment #126762 - Attachment is obsolete: true
as a note, it seems impossible to change the text of the "Open" button on windows
No plans to work on this any time in the foreseeable future, so to default owner.
Assignee: bz-vacation → file-handling
QA Contact: chrispetersen → ian
Priority: P3 → --
Target Milestone: mozilla1.6beta → ---
Assignee: file-handling → nobody
QA Contact: ian → file-handling
Confirming the "Open" button issue is still reproducible with Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0 SeaMonkey/2.16.1. (The file selection dialog title was fixed long ago.)
Component: File Handling → File Handling
Product: Core → Firefox
Version: Trunk → unspecified
Confirming the "Open" button issue is still reproducible with Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40. The problem doesn't seem to exist in Firefox 49.0.2 -- at least, not the GNU/Linux version. There the "Choose Helper Application" dialog is not a vanilla file selector dialog, but instead presents a list of applications registered with the desktop environment. Benjamin, is there a reason why you reassigned the product to Firefox? Or should this instead have stayed with Core, or been reassigned to SeaMonkey?
We removed/unified the Core: File Handling component because nobody was quite clear on why there were two components for basically the same thing.
But the problem doesn't exist with Firefox, so perhaps this bug should be assigned to SeaMonkey.
You need to log in before you can comment on or make changes to this bug.